Copybara import of the project:#11349
Closed
copybara-service[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
-- 3eac250 by Josh Humphries <[email protected]>: add check for custom JSON name conflicts - also, include check for default JSON name conflicts even in proto2 files (but only warn) - if custom JSON name conflicts with other default name, only a warning in proto2 -- b23b387 by Josh Humphries <[email protected]>: update existing test expectations and add new tests -- aa34e0e by Josh Humphries <[email protected]>: JSON -> Json -- fdaa464 by Josh Humphries <[email protected]>: address review feedback wrt absl string functions also moves helpers into anonymous namespace -- 6d5f2fc by Josh Humphries <[email protected]>: apply clang-format changes; change really long pair type to auto -- 81b5cbe by Josh Humphries <[email protected]>: address review feedback -- 8fa8b10 by Josh Humphries <[email protected]>: return struct instead of using out param -- b405717 by Josh Humphries <[email protected]>: address review feedback COPYBARA_INTEGRATE_REVIEW=#10750 from jhump:jh/custom-json-name-validation b405717 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10750 from jhump:jh/custom-json-name-validation b405717 PiperOrigin-RevId: 485415358
copybara-service
bot
force-pushed
the
test_485415358
branch
2 times, most recently
from
c6e0e73 to
535069e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara import of the project:
--
3eac250 by Josh Humphries [email protected]:
add check for custom JSON name conflicts
files (but only warn)
warning in proto2
--
b23b387 by Josh Humphries [email protected]:
update existing test expectations and add new tests
--
aa34e0e by Josh Humphries [email protected]:
JSON -> Json
--
fdaa464 by Josh Humphries [email protected]:
address review feedback wrt absl string functions
also moves helpers into anonymous namespace
--
6d5f2fc by Josh Humphries [email protected]:
apply clang-format changes; change really long pair type to auto
--
81b5cbe by Josh Humphries [email protected]:
address review feedback
--
8fa8b10 by Josh Humphries [email protected]:
return struct instead of using out param
--
b405717 by Josh Humphries [email protected]:
address review feedback
COPYBARA_INTEGRATE_REVIEW=#10750 from jhump:jh/custom-json-name-validation b405717
FUTURE_COPYBARA_INTEGRATE_REVIEW=#10750 from jhump:jh/custom-json-name-validation b405717