Auto capitalize enums name in Ruby (#10454)#10708
Merged
deannagarcia merged 1 commit intoprotocolbuffers:mainfrom Oct 6, 2022
Merged
Auto capitalize enums name in Ruby (#10454)#10708deannagarcia merged 1 commit intoprotocolbuffers:mainfrom
deannagarcia merged 1 commit intoprotocolbuffers:mainfrom
Conversation
Contributor
Author
|
ping @JasonLunn @mkruskal-google could you help with triggering the tests? |
mkruskal-google
added
kokoro:run
ruby
jruby
deannagarcia
approved these changes
Oct 6, 2022
Member
|
Thanks for upstreaming this! We don't have a planned date for the next release but should be within the next few weeks. |
Contributor
Author
|
@deannagarcia @mkruskal-google emmm...IIRC I open this PR against 21.x but it's now merged into master (and I don't find the commit on master). What should I do now? @deannagarcia @mkruskal-google could you help with cherrypicking this patch? |
Contributor
Author
|
I create a new PR. This time I confirm that it's against 21.x:
If you'd like to proceed it, be careful before you click the merge button - I don't know what happened here :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks #10454 to branch-2.11. Refer to #1965.
cc @JasonLunn @mkruskal-google