Fix Timestamps fromDate for negative 'exact second' java.sql.Timestamps#10321
Merged
deannagarcia merged 1 commit intoprotocolbuffers:mainfrom Aug 8, 2022
Merged
Conversation
deannagarcia
approved these changes
Aug 8, 2022
Member
deannagarcia
left a comment
deannagarcia
left a comment
There was a problem hiding this comment.
Thanks for the fix and the added test!!
srowen
pushed a commit
to apache/spark
that referenced
this pull request
Feb 20, 2023
### What changes were proposed in this pull request? This pr aims upgrade `protobuf-java` from 3.21.12 to 3.22.0 ### Why are the changes needed? The new version bring some improvements like: - Use bit-field int values in buildPartial to skip work on unset groups of fields. (protocolbuffers/protobuf@2326aef) - Fix serialization warnings in generated code when compiling with Java 18 and above (protocolbuffers/protobuf#10561) - Enable Text format parser to skip unknown short-formed repeated fields. (protocolbuffers/protobuf@6dbd413) - Add serialVersionUID to ByteString and subclasses (protocolbuffers/protobuf#10718) and some bug fix like: - Mark default instance as immutable first to avoid race during static initialization of default instances. (protocolbuffers/protobuf#10770) - Fix Timestamps fromDate for negative 'exact second' java.sql.Timestamps (protocolbuffers/protobuf#10321) - Fix Timestamps.fromDate to correctly handle java.sql.Timestamps before unix epoch (protocolbuffers/protobuf#10126) - Fix bug in nested builder caching logic where cleared sub-field builders would remain dirty after a clear and build in a parent layer. protocolbuffers/protobuf#10624 The release notes as follows: - https://github.com/protocolbuffers/protobuf/releases/tag/v22.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes #40084 from LuciferYang/SPARK-42490. Authored-by: yangjie01 <[email protected]> Signed-off-by: Sean Owen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(-1000/1000) -1 = -2s // This is what the code used to incorrectly do
(-999/1000) - 1 = -1s // This is correct