Ruby implement memsize functions for native types by casperisfine · Pull Request #10291 · protocolbuffers/protobuf

casperisfine · 2022-07-21T06:38:28Z

This allows Ruby to report a more correct estimation of the memory used by these objects.

It's useful when running memory profilers against applications.

casperisfine · 2022-08-03T08:57:36Z

@haberman thanks. I updated Arena_memsize according to your suggestions.

haberman · 2022-08-10T00:59:04Z

Thanks for the changes. Would you be able to submit the ruby-upb.c/.h changes to https://github.com/protocolbuffers/upb/blob/main/upb/arena.h and https://github.com/protocolbuffers/upb/blob/main/upb/arena.c, which is that code's primary location.

We can create a new function upb_Arena_SpaceAllocated() that is then called from here.

Ref: protocolbuffers/protobuf#10291 Ruby types defined though native extensions should register a function that report their memory footprint in bytes. This feature is used by various memory profiling tools.

casperisfine · 2022-08-10T08:34:26Z

. Would you be able to submit the ruby-upb.c/.h changes to ...

Done! protocolbuffers/upb#729

Ref: protocolbuffers/protobuf#10291 Ruby types defined though native extensions should register a function that report their memory footprint in bytes. This feature is used by various memory profiling tools.

haberman · 2023-02-16T22:07:07Z

If you rebase on main it should pick up the upb_Arena_SpaceAllocated() function that is there now.

casperisfine · 2023-02-17T07:19:45Z

Rebeased.

haberman · 2023-02-27T23:17:08Z

I think we need one more rebase here (I think this conflicted with your other change).

casperisfine · 2023-02-28T07:55:54Z

Oh wow, I had forgotten about this one. I'll rebase.

Fix: protocolbuffers#10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications.

casperisfine · 2023-02-28T07:59:44Z

Done.

haberman · 2023-02-28T17:13:15Z

The Ruby 2.6 test failed with:

ruby/ext/google/protobuf_c/protobuf.c:417: void ObjectCache_Add(const void *, VALUE): Assertion `ObjectCache_Get(key) == val' failed.
Aborted (core dumped)

It's hard to see how this PR would have caused that error. I'll try re-running that test.

github-actions · 2024-01-07T10:02:40Z

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@zhangskz

Fix: #10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications. cc @zhangskz @haberman Closes #10291 COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 PiperOrigin-RevId: 606424604

@zhangskz

Fix: #10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications. cc @zhangskz @haberman Closes #10291 COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 PiperOrigin-RevId: 606424604

@zhangskz

Fix: #10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications. cc @zhangskz @haberman Closes #10291 COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 PiperOrigin-RevId: 606424604

@zhangskz

Fix: #10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications. cc @zhangskz @haberman Closes #10291 COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 PiperOrigin-RevId: 606424604

@zhangskz

Fix: #10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications. cc @zhangskz @haberman Closes #10291 COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 PiperOrigin-RevId: 606718632

@zhangskz

Fix: #10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications. cc @zhangskz @haberman Closes #10291 COPYBARA_INTEGRATE_REVIEW=#10291 from casperisfine:ruby-sizes 9150795 PiperOrigin-RevId: 606718632

Ruby implement memsize functions for native types (#10291)

@zhangskz

) Fix: protocolbuffers#10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications. cc @zhangskz @haberman Closes protocolbuffers#10291 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#10291 from casperisfine:ruby-sizes 9150795 PiperOrigin-RevId: 606718632

These tests are for CRuby native implementation. So this doesn't work with FFI and JRuby. Ref: protocolbuffers#10291

casperisfine commented Jul 21, 2022

View reviewed changes

Comment thread ruby/ext/google/protobuf_c/map.c

Comment thread ruby/ext/google/protobuf_c/message.c

Comment thread ruby/ext/google/protobuf_c/protobuf.c Outdated

acozzette added ruby release notes: yes labels Jul 21, 2022

protobuf-kokoro removed the kokoro:run label Jul 21, 2022

acozzette requested a review from haberman July 21, 2022 17:04

casperisfine force-pushed the ruby-sizes branch from 4fef77e to 671c09d Compare August 3, 2022 08:57

casperisfine force-pushed the ruby-sizes branch from 671c09d to ab9b741 Compare August 3, 2022 10:26

haberman added the kokoro:run label Aug 8, 2022

protobuf-kokoro removed the kokoro:run label Aug 8, 2022

casperisfine mentioned this pull request Aug 10, 2022

Add upb_Arena_SpaceAllocated function protocolbuffers/upb#729

Merged

casperisfine force-pushed the ruby-sizes branch from ab9b741 to a6be214 Compare August 10, 2022 08:34

googleberg assigned haberman Oct 13, 2022

casperisfine force-pushed the ruby-sizes branch from a6be214 to 0143e80 Compare February 17, 2023 07:19

casperisfine requested a review from a team as a code owner February 17, 2023 07:19

haberman added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 17, 2023

Ruby implement memsize functions for native types

9150795

Fix: protocolbuffers#10280 This allows Ruby to report a more correct estimation of the memory used by these objects. It's useful when running memory profilers against applications.

casperisfine force-pushed the ruby-sizes branch from 0143e80 to 9150795 Compare February 28, 2023 07:59

haberman added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 28, 2023

github-actions Bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 28, 2023

github-actions Bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jan 7, 2024

haberman approved these changes Jan 8, 2024

View reviewed changes

github-actions Bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jan 14, 2024

copybara-service Bot mentioned this pull request Feb 13, 2024

Ruby implement memsize functions for native types (#10291) #15811

Merged

copybara-service Bot closed this in 87cbddd Feb 13, 2024

protobuf-team-bot added a commit that referenced this pull request Feb 13, 2024

Auto-generate files after PR #10291

a3c33a8

zhangskz mentioned this pull request Feb 14, 2024

Ruby implement memsize functions for native types (#10291) #15840

Merged

zhangskz added a commit that referenced this pull request Feb 16, 2024

Merge pull request #15840 from protocolbuffers/cp-ruby-memsize

80bd80f

Ruby implement memsize functions for native types (#10291)

deannagarcia pushed a commit to deannagarcia/protobuf that referenced this pull request Jun 20, 2024

Auto-generate files after PR protocolbuffers#10291

7c50743

y-yagi added a commit to y-yagi/protobuf that referenced this pull request Jan 10, 2025

Run memory tests against CRuby native implementation

11b5996

These tests are for CRuby native implementation. So this doesn't work with FFI and JRuby. Ref: protocolbuffers#10291

y-yagi added a commit to y-yagi/protobuf that referenced this pull request Jan 12, 2025

Run memory tests against CRuby native implementation

3beb9de

These tests are for CRuby native implementation. So this doesn't work with FFI and JRuby. Ref: protocolbuffers#10291

y-yagi mentioned this pull request Jan 12, 2025

Add some missing tests to the test setting of Bazel for Ruby #19870

Closed

y-yagi added a commit to y-yagi/protobuf that referenced this pull request Jan 14, 2025

Run memory tests against CRuby native implementation

8e6e60a

These tests are for CRuby native implementation. So this doesn't work with FFI and JRuby. Ref: protocolbuffers#10291

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ruby implement memsize functions for native types#10291

Ruby implement memsize functions for native types#10291
casperisfine wants to merge 1 commit intoprotocolbuffers:mainfrom
casperisfine:ruby-sizes

casperisfine commented Jul 21, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

casperisfine commented Aug 3, 2022

Uh oh!

haberman commented Aug 10, 2022

Uh oh!

casperisfine commented Aug 10, 2022

Uh oh!

haberman commented Feb 16, 2023

Uh oh!

casperisfine commented Feb 17, 2023

Uh oh!

haberman commented Feb 27, 2023

Uh oh!

casperisfine commented Feb 28, 2023

Uh oh!

casperisfine commented Feb 28, 2023

Uh oh!

haberman commented Feb 28, 2023

Uh oh!

github-actions Bot commented Jan 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

casperisfine commented Jul 21, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

casperisfine commented Aug 3, 2022

Uh oh!

haberman commented Aug 10, 2022

Uh oh!

casperisfine commented Aug 10, 2022

Uh oh!

haberman commented Feb 16, 2023

Uh oh!

casperisfine commented Feb 17, 2023

Uh oh!

haberman commented Feb 27, 2023

Uh oh!

casperisfine commented Feb 28, 2023

Uh oh!

casperisfine commented Feb 28, 2023

Uh oh!

haberman commented Feb 28, 2023

Uh oh!

github-actions Bot commented Jan 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants