I've been looking at this today, and trying to work out how we can support it reasonably simply without adding too much to the API surface area. One issue is that options can be of any of the various types available - messages, strings, scalars etc.

If FieldDescriptor, MethodDescriptor, MessageDescriptor etc were to have a method such as:

IList<ByteString> GetOptions(int fieldNumber)

would that be enough to start with? I'd need to also provide a CodedInputStream constructor accepting a ByteString, but basically the idea would be:

For messages, you'd just call YourMessage.Parser.Parse(value)
For strings, you'd call value.ToStringUtf8
For byte strings, you'd already have the value
For scalars, you'd create a CodedInputStream and read the value from that

You'd need to know the option's field number, which I wouldn't initially be generating any support for. In future, we could potentially generate a helper class for each option, which would know the right type, the field number etc - but that would take quite a bit more work. This "halfway house" would at least unblock users.

Thoughts?

Support custom options in C# #2143

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions