Skip to content

protobuf_generate passes options in the wrong order to protoc. #12375

@MSK61

Description

@MSK61

ARGS ${protobuf_generate_PROTOC_OPTIONS} --${protobuf_generate_LANGUAGE}_out ${_plugin_options}:${protobuf_generate_PROTOC_OUT_DIR} ${_plugin} ${_protobuf_include_path} ${_abs_file}

The plugin options ${_plugin_options} are misplaced between --${protobuf_generate_LANGUAGE}_out and ${protobuf_generate_PROTOC_OUT_DIR}. Even stranger, the options are nonsensically concatenated with a colon : to ${protobuf_generate_PROTOC_OUT_DIR}. I think the correct format for the arguments should be something like:

ARGS ${protobuf_generate_PROTOC_OPTIONS} --${protobuf_generate_LANGUAGE}_out ${protobuf_generate_PROTOC_OUT_DIR} ${_plugin_options} ${_plugin} ${_protobuf_include_path} ${_abs_file}

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions