Run service options extension test against CRuby native implementation

y-yagi · y-yagi · commit d51158def9c4 · 2025-01-14T16:43:36.000+09:00
It seems that JRuby doesn't support this so far. And, service options are frozen objects. But, in CRuby FFI, can't get a Message instance if the message is frozen. So this doesn't work. https://github.com/protocolbuffers/protobuf/blob/d406cae0138f4f1f283a22be9474bef1f48bb0dc/ruby/lib/google/protobuf/ffi/message.rb#L419 So the service options extension test only passes in CRuby native.
diff --git a/ruby/tests/service_test.rb b/ruby/tests/service_test.rb
@@ -33,6 +33,7 @@ def test_service_options
   end
 
   def test_service_options_extensions
+    omit "JRuby and FFI do not support service options extensions" if defined?(JRUBY_VERSION) || Google::Protobuf::IMPLEMENTATION != :NATIVE
     extension_field = Google::Protobuf::DescriptorPool.generated_pool.lookup('service_test_protos.test_options')
     assert_equal 8325, extension_field.get(@test_service.options).int_option_value
   end
