Breaking Change: Stop generating the "newInstance" method. This is not used anymore.

protobuf-github-bot · copybara-github · commit c0d08bdcade9 · 2024-01-20T12:54:32.000-08:00
PiperOrigin-RevId: 600123108
diff --git a/java/core/src/main/java/com/google/protobuf/NewInstanceSchemaFull.java b/java/core/src/main/java/com/google/protobuf/NewInstanceSchemaFull.java
@@ -10,7 +10,6 @@
 final class NewInstanceSchemaFull implements NewInstanceSchema {
   @Override
   public Object newInstance(Object defaultInstance) {
-    return ((GeneratedMessage) defaultInstance)
-        .newInstance(GeneratedMessage.UnusedPrivateParameter.INSTANCE);
+    return ((Message) defaultInstance).toBuilder().buildPartial();
   }
 }
diff --git a/src/google/protobuf/compiler/java/message.cc b/src/google/protobuf/compiler/java/message.cc
@@ -357,15 +357,6 @@ void ImmutableMessageGenerator::Generate(io::Printer* printer) {
       "}\n"
       "\n");
 
-  printer->Print(variables,
-                 "@java.lang.Override\n"
-                 "@SuppressWarnings({\"unused\"})\n"
-                 "protected java.lang.Object newInstance(\n"
-                 "    UnusedPrivateParameter unused) {\n"
-                 "  return new $classname$();\n"
-                 "}\n"
-                 "\n");
-
   GenerateDescriptorMethods(printer);
 
   // Nested types

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@`
`10`	`10`	`final class NewInstanceSchemaFull implements NewInstanceSchema {`
`11`	`11`	`@Override`
`12`	`12`	`public Object newInstance(Object defaultInstance) {`
`13`		`- return ((GeneratedMessage) defaultInstance)`
`14`		`- .newInstance(GeneratedMessage.UnusedPrivateParameter.INSTANCE);`
	`13`	`+ return ((Message) defaultInstance).toBuilder().buildPartial();`
`15`	`14`	`}`
`16`	`15`	`}`