Fix some -Wunused-parameter warnings which appeared in release 3.13.0.

Romain-Geissler-1A · Adam Cozzette · commit 76f9074c1c94 · 2020-09-03T09:11:11.000-07:00
diff --git a/src/google/protobuf/generated_message_reflection.h b/src/google/protobuf/generated_message_reflection.h
@@ -214,15 +214,15 @@ struct ReflectionSchema {
 
   // Returns true if the field's accessor is called by any external code (aka,
   // non proto library code).
-  bool IsFieldUsed(const FieldDescriptor* field) const {
+  bool IsFieldUsed(const FieldDescriptor* /* field */) const {
     return true;
   }
 
-  bool IsFieldStripped(const FieldDescriptor* field) const {
+  bool IsFieldStripped(const FieldDescriptor* /* field */) const {
     return false;
   }
 
-  bool IsMessageStripped(const Descriptor* descriptor) const {
+  bool IsMessageStripped(const Descriptor* /* descriptor */) const {
     return false;
   }
 
diff --git a/src/google/protobuf/message.h b/src/google/protobuf/message.h
@@ -1045,7 +1045,7 @@ class PROTOBUF_EXPORT Reflection final {
                              const OneofDescriptor* oneof_descriptor) const;
   inline uint32* MutableOneofCase(
       Message* message, const OneofDescriptor* oneof_descriptor) const;
-  inline bool HasExtensionSet(const Message& message) const {
+  inline bool HasExtensionSet(const Message& /* message */) const {
     return schema_.HasExtensionSet();
   }
   const internal::ExtensionSet& GetExtensionSet(const Message& message) const;

Original file line number	Diff line number	Diff line change
`@@ -214,15 +214,15 @@ struct ReflectionSchema {`
`214`	`214`
`215`	`215`	`// Returns true if the field's accessor is called by any external code (aka,`
`216`	`216`	`// non proto library code).`
`217`		`- bool IsFieldUsed(const FieldDescriptor* field) const {`
	`217`	`+ bool IsFieldUsed(const FieldDescriptor* /* field */) const {`
`218`	`218`	`return true;`
`219`	`219`	`}`
`220`	`220`
`221`		`- bool IsFieldStripped(const FieldDescriptor* field) const {`
	`221`	`+ bool IsFieldStripped(const FieldDescriptor* /* field */) const {`
`222`	`222`	`return false;`
`223`	`223`	`}`
`224`	`224`
`225`		`- bool IsMessageStripped(const Descriptor* descriptor) const {`
	`225`	`+ bool IsMessageStripped(const Descriptor* /* descriptor */) const {`
`226`	`226`	`return false;`
`227`	`227`	`}`
`228`	`228`
Original file line number	Diff line number	Diff line change
`@@ -1045,7 +1045,7 @@ class PROTOBUF_EXPORT Reflection final {`
`1045`	`1045`	`const OneofDescriptor* oneof_descriptor) const;`
`1046`	`1046`	`inline uint32* MutableOneofCase(`
`1047`	`1047`	`Message* message, const OneofDescriptor* oneof_descriptor) const;`
`1048`		`- inline bool HasExtensionSet(const Message& message) const {`
	`1048`	`+ inline bool HasExtensionSet(const Message& /* message */) const {`
`1049`	`1049`	`return schema_.HasExtensionSet();`
`1050`	`1050`	`}`
`1051`	`1051`	`const internal::ExtensionSet& GetExtensionSet(const Message& message) const;`