Fixed memory leak of Ruby arena objects.

haberman · haberman · commit 67fee915e01a · 2021-04-07T10:30:51.000-07:00
In our free() method, we were freeing the memory from the
upb arena but we were failing to free the memory for the
Ruby arena object. This was causing every Ruby arena object
to leak: even though the objects were getting GC'd, the
underlying memory was not getting released.
diff --git a/ruby/ext/google/protobuf_c/protobuf.c b/ruby/ext/google/protobuf_c/protobuf.c
@@ -180,6 +180,7 @@ static void Arena_mark(void *data) {
 static void Arena_free(void *data) {
   Arena *arena = data;
   upb_arena_free(arena->arena);
+  xfree(arena);
 }
 
 static VALUE cArena;

Original file line number	Diff line number	Diff line change
`@@ -180,6 +180,7 @@ static void Arena_mark(void *data) {`
`180`	`180`	`static void Arena_free(void *data) {`
`181`	`181`	`Arena *arena = data;`
`182`	`182`	`upb_arena_free(arena->arena);`
	`183`	`+ xfree(arena);`
`183`	`184`	`}`
`184`	`185`
`185`	`186`	`static VALUE cArena;`