Performance fix for DynamicMessage: force GetRaw() to be inlined.

haberman · haberman · commit 5e8396fd2743 · 2021-09-24T15:17:30.000-07:00
diff --git a/src/google/protobuf/dynamic_message.cc b/src/google/protobuf/dynamic_message.cc
@@ -355,7 +355,7 @@ DynamicMessage::DynamicMessage(DynamicMessageFactory::TypeInfo* type_info,
   SharedCtor(lock_factory);
 }
 
-void* DynamicMessage::MutableRaw(int i) {
+inline void* DynamicMessage::MutableRaw(int i) {
   return OffsetToPointer(
       OffsetValue(type_info_->offsets[i], type_info_->type->field(i)->type()));
 }

Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ DynamicMessage::DynamicMessage(DynamicMessageFactory::TypeInfo* type_info,`
`355`	`355`	`SharedCtor(lock_factory);`
`356`	`356`	`}`
`357`	`357`
`358`		`-void* DynamicMessage::MutableRaw(int i) {`
	`358`	`+inline void* DynamicMessage::MutableRaw(int i) {`
`359`	`359`	`return OffsetToPointer(`
`360`	`360`	`OffsetValue(type_info_->offsets[i], type_info_->type->field(i)->type()));`
`361`	`361`	`}`