Use the 'better' JSON parser on the conformance suite harness.

protobuf-github-bot · copybara-github · commit 4b4e405491be · 2025-08-26T06:47:26.000-07:00
This switches it to use the Descriptor-based path instead of the type.proto-based path, which also unlocks the ability to test for handling of extensions.

PiperOrigin-RevId: 799542063
diff --git a/conformance/binary_json_conformance_suite.cc b/conformance/binary_json_conformance_suite.cc
@@ -232,22 +232,14 @@ namespace protobuf {
 
 bool BinaryAndJsonConformanceSuite::ParseJsonResponse(
     const ConformanceResponse& response, Message* test_message) {
-  std::string binary_protobuf;
+  json::ParseOptions options;
+  options.allow_legacy_nonconformant_behavior = false;
   absl::Status status =
-      json::JsonToBinaryString(type_resolver_.get(), type_url_,
-                               response.json_payload(), &binary_protobuf);
-
+      json::JsonStringToMessage(response.json_payload(), test_message);
   if (!status.ok()) {
     ABSL_LOG(ERROR) << status;
     return false;
   }
-
-  if (!test_message->ParseFromString(binary_protobuf)) {
-    ABSL_LOG(FATAL) << "INTERNAL ERROR: internal JSON->protobuf transcode "
-                    << "yielded unparseable proto.";
-    return false;
-  }
-
   return true;
 }
 
