Treat warnings encountered in chromium builds as errors.

tonyliaoss · copybara-github · commit 21c3c5319634 · 2025-06-16T13:26:50.000-07:00
Chromium x86_64 builds with -Wconstant-conversion and -Wunused-label as errors.
Since chromium is an important protobuf customer, we should preferably be
detecting their build failures as early as possible (in development time).

PiperOrigin-RevId: 772147894
diff --git a/src/google/protobuf/port_def.inc b/src/google/protobuf/port_def.inc
@@ -780,6 +780,10 @@ static_assert(PROTOBUF_ABSL_MIN(20230125, 3),
 // Turn on -Wdeprecated-enum-enum-conversion. This deprecation comes in C++20
 // via http://wg21.link/p1120r0.
 #pragma clang diagnostic error "-Wdeprecated-enum-enum-conversion"
+// Turn on -Wconstant-conversion which is used in chromiumos_x86_64 builds.
+#pragma clang diagnostic error "-Wconstant-conversion"
+// Turn on -Wunused-label which is used in chromiumos_x86_64 builds.
+#pragma clang diagnostic error "-Wunused-label"
 // This error has been generally flaky, but we need to disable it specifically
 // to fix https://github.com/protocolbuffers/protobuf/issues/12313
 #pragma clang diagnostic ignored "-Wunused-parameter"
