Simplify (and optimize) Descriptors.FileDescriptor.latin1Cat.

lowasser · copybara-github · commit 0ee34d35def2 · 2024-02-01T17:31:31.000-08:00
PiperOrigin-RevId: 603529248
diff --git a/java/core/src/main/java/com/google/protobuf/Descriptors.java b/java/core/src/main/java/com/google/protobuf/Descriptors.java
@@ -415,11 +415,7 @@ private static byte[] latin1Cat(final String[] strings) {
       if (strings.length == 1) {
         return strings[0].getBytes(Internal.ISO_8859_1);
       }
-      StringBuilder descriptorData = new StringBuilder();
-      for (String part : strings) {
-        descriptorData.append(part);
-      }
-      return descriptorData.toString().getBytes(Internal.ISO_8859_1);
+      return String.join("", strings).getBytes(Internal.ISO_8859_1);
     }
 
     private static FileDescriptor[] findDescriptors(

Original file line number	Diff line number	Diff line change
`@@ -415,11 +415,7 @@ private static byte[] latin1Cat(final String[] strings) {`
`415`	`415`	`if (strings.length == 1) {`
`416`	`416`	`return strings[0].getBytes(Internal.ISO_8859_1);`
`417`	`417`	`}`
`418`		`- StringBuilder descriptorData = new StringBuilder();`
`419`		`- for (String part : strings) {`
`420`		`- descriptorData.append(part);`
`421`		`- }`
`422`		`- return descriptorData.toString().getBytes(Internal.ISO_8859_1);`
	`418`	`+ return String.join("", strings).getBytes(Internal.ISO_8859_1);`
`423`	`419`	`}`
`424`	`420`
`425`	`421`	`private static FileDescriptor[] findDescriptors(`