Fixed: prevent codegen'ing a function with an invalid name.#870
Fixed: prevent codegen'ing a function with an invalid name.#870eventualbuddha wants to merge 1 commit intoprotobufjs:masterfrom eventualbuddha:prevent-codegen-from-using-keyword-function-names
Conversation
This can happen when, for example, an RPC method name is the uppercase of a keyword like "Delete".
|
Ping. |
|
Is this project unmaintained? Do I need to do something before this can be considered? |
|
Thanks, but this doesn't fix the underlying issue since these function might still be called by other parts of the library, using their original name. Instead, we should make sure that invalid names are handled on the reflection level. |
|
The commit above should prevent the parse error in runtime code while still naming the method |
|
Cool, that seems like a good approach. Thanks for looking at this! |
|
@dcodeIO so is your solution finished? Anything I can do to help? |
|
The changes are live, latest on npm is 6.8.3. Have you tested with this one? |
|
Oh cool, I’ll try it out tomorrow. I had assumed that since the issue was still open that the problem remained. |
|
Closing for now, feel free to report any remaining issues. |
2 participants
This can happen when, for example, an RPC method name is the uppercase of a keyword like "Delete". I tried to retain the performance of the original, but since the test just uses the same names over and over again and they're memoized it's not a super representative set of test data to really understand how the performance changed.