Skip to content

fix RPCImplCallback type declaration - make Error optional#766

Closed
rossenassenov wants to merge 2 commits intoprotobufjs:masterfrom
rossenassenov:fix_index_dts
Closed

fix RPCImplCallback type declaration - make Error optional#766
rossenassenov wants to merge 2 commits intoprotobufjs:masterfrom
rossenassenov:fix_index_dts

Conversation

@rossenassenov
Copy link
Copy Markdown

No description provided.

@dcodeIO
Copy link
Copy Markdown
Member

dcodeIO commented Apr 19, 2017

index.d.ts is a generated file and any changes will be overwritten on rebuild. Actual source location is: https://github.com/dcodeIO/protobuf.js/blob/master/src/rpc.js#L28

@param {Error|null} then, probably.

@rossenassenov
Copy link
Copy Markdown
Author

rossenassenov commented Apr 19, 2017

@dcodeIO
Copy link
Copy Markdown
Member

dcodeIO commented Apr 20, 2017

But is it actually optional? It cannot be undefined. There is either an Error, or none (null).

@dcodeIO dcodeIO closed this in 23f4b99 Apr 20, 2017
@rossenassenov rossenassenov deleted the fix_index_dts branch April 20, 2017 18:39
@rossenassenov
Copy link
Copy Markdown
Author

thanks for the fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants