Make validate support optional fields#562
Closed
mkmik wants to merge 1 commit intoprotobufjs:masterfrom
mkmik:master
Closed
Make validate support optional fields#562mkmik wants to merge 1 commit intoprotobufjs:masterfrom mkmik:master
mkmik wants to merge 1 commit intoprotobufjs:masterfrom
mkmik:master
Conversation
Member
|
Optional fields should already be checked here when present. Are you experiencing any issues? Maybe |
dcodeIO
added a commit
that referenced
this pull request
Dec 15, 2016
Contributor
Author
|
yes I added this check because that generated function was entered with m == null when an optional field was omitted. or at least the stack trace said that null has no such property. afk atm, I can attach a failing case when I'm back |
Member
|
I assume that the |
Contributor
Author
|
I confirm that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.