Skip to content

Remove jsdoc includePattern#2089

Merged
dcodeIO merged 1 commit intoprotobufjs:masterfrom
joshkel:jsdoc-filter
Apr 24, 2026
Merged

Remove jsdoc includePattern#2089
dcodeIO merged 1 commit intoprotobufjs:masterfrom
joshkel:jsdoc-filter

Conversation

@joshkel
Copy link
Copy Markdown
Contributor

@joshkel joshkel commented Aug 1, 2025

As explained at https://jsdoc.app/about-configuring-jsdoc#specifying-input-files, jsdoc uses a default includePattern of ".+\.js(doc|x)?$" and filters out files (even files explicitly given on the command line) that do not match this pattern.

pbts always runs on a single, explicitly given file, so it should disable includePattern.

Fixes #2088

As explained at https://jsdoc.app/about-configuring-jsdoc#specifying-input-files, jsdoc uses a default includePattern of ".+\\.js(doc|x)?$" and filters out files (even files explicitly given on the command line) that do not match this pattern.

pbts always runs on a single, explicitly given file, so it should disable includePattern.

Fixes #2088
@dcodeIO dcodeIO merged commit 0fead2e into protobufjs:master Apr 24, 2026
6 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 24, 2026
dcodeIO added a commit that referenced this pull request Apr 24, 2026
@joshkel joshkel deleted the jsdoc-filter branch April 24, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running pbts on non-.js extensions fails

2 participants