feat: add feature resolution for protobuf editions#2029
Merged
Conversation
sofisl
commented
Sep 19, 2024
sofisl
commented
Sep 20, 2024
| // (If it's a feature, will just write over) | ||
| var newValue = opt[name]; | ||
| util.setProperty(newValue, propName, value); | ||
| util.setProperty(newValue, propName, value, isFeature); |
Contributor
There was a problem hiding this comment.
typo, the regex is only wrong if name is the fully feature path. If it's always just features, this will overwrite the entire features object for each specified feature right? It'll only keep the last one?
| message Message { | ||
| option features.json_format = LEGACY_BEST_EFFORT; | ||
| oneof SomeOneOf { | ||
| int32 a = 13; |
Contributor
There was a problem hiding this comment.
you can put features in oneofs (same syntax as for message), do those work?
Contributor
There was a problem hiding this comment.
Following the pattern of your other tests, I'd expect these two tests to be collapsed into one that tests both inheritance and overriding of message -> oneof
Contributor
Author
There was a problem hiding this comment.
isn't that tested in the test below? (feature resolution inheritance oneofs)
Contributor
There was a problem hiding this comment.
Kindof, it's not clear why this one is split into two when all of the other ones test both things in a single test
Contributor
Author
There was a problem hiding this comment.
ok I merged it into one test!
mkruskal-google
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.