fix: type names can be split into multiple tokens#1877
Merged
alexander-fenster merged 1 commit intomasterfrom Mar 27, 2023
Merged
fix: type names can be split into multiple tokens#1877alexander-fenster merged 1 commit intomasterfrom
alexander-fenster merged 1 commit intomasterfrom
Conversation
bcoe
approved these changes
Mar 22, 2023
Contributor
Author
|
Parser changes are scary, so if anyone from the community could review this, I would be grateful :) I will hold off merging for a day or two in hope someone else takes a look. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some proto packages are pretty long, and some proto formatters might split them into multiple lines in a weird way, like here:
https://github.com/googleapis/googleapis/blob/master/google/ads/googleads/v13/common/asset_set_types.proto#L176-L177
The parser expects the whole type name to be just one token, and fails to parse this. I'm fixing the parser to accept multiple tokens as the type name: keep glueing tokens together while there are periods that separate parts of the type name.