Work around missing interfaces with jsdoc >3.5.5 (fixes #1414)#1844
Open
buu700 wants to merge 1 commit intoprotobufjs:masterfrom
Open
Work around missing interfaces with jsdoc >3.5.5 (fixes #1414)#1844buu700 wants to merge 1 commit intoprotobufjs:masterfrom
buu700 wants to merge 1 commit intoprotobufjs:masterfrom
Conversation
credit for this solution goes to @jolting: protobufjs#1414 (comment)
Closed
buu700
added a commit
to buu700/protobufjs-cli-tmp
that referenced
this pull request
Jan 6, 2023
Author
|
Ah, great! I'll leave this open for the sake of keeping attention on the issue, but I agree that version should be merged instead. |
buu700
added a commit
to cyph/cyph
that referenced
this pull request
Jul 30, 2023
…and protobufjs/protobuf.js#1844" This reverts commit c74c2f9.
koad
pushed a commit
to koad/cyph
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit for this solution goes to @jolting: #1414 (comment)
I've also confirmed that this works with the latest jsdoc (4.0.0), so please merge #1833 as well.