Don't include @exports for enums#1824
Conversation
jsdoc states : > Use the @exports tag when documenting JavaScript modules that export anything" > other than the "exports" object or the "module.exports" property. It is not intended to be used to specify an export name. TLDR: There should be only one `@exports` per file. Maybe $root for non-es6 modules. ES6 modules should use `@module` The other `@exports` don't appear to be causing problems. However, they are incorrect as well. Fixes protobufjs#1414
|
I have tested it. It is really solves my issue where pbts does not generate interfaces for enum but use implements from interfases which does not exists. |
|
Good news! I have been waiting this fix for 2 years! |
|
Also it fixes other my issue. Once I was surprised when building of my project was broken, despite the fact that I locked the dependency tree. |
theCodeMachine
left a comment
theCodeMachine
left a comment
There was a problem hiding this comment.
It fixes the issue! I am able to generate typescript definitions correctly with this
|
@bcoe @alexander-fenster please pardon my ping but what is preventing this pr from being merged? |
There was a problem hiding this comment.
Can we get this merged? Our team has to locally patch and build protobufjs. Let's merge this 1-line fix. Tagging @alexander-fenster @sofisl
|
yeah. our team has to locally path and build protobuffjs as well. |
11 participants
jsdoc states :
It is not intended to be used to specify an export name. TLDR: There should be only one
@exportsper file. Maybe $root for non-es6 modules.ES6 modules should use
@moduleThe other
@exportsdon't appear to be causing problems. However, they are incorrect as well.Fixes #1414