You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just encountered the same problem. @types/[email protected] is causing an additional Long type that's incompatible with the builtin Long type from [email protected]. Had to add import Long from "long"; to generated proto.d.ts to prevent it from picking up the wrong Long from @types/long.
Well, this happens to be harder than I thought - adding this actually breaks some code that depended on import * as Long from 'long' being possible, so it's a breaking change. I will need to roll it back now and think how we could proceed here.
Maybe not rollback, since we actually have more packages doing the same thing with long, but I'll take some time before releasing that to make sure other code I care about does not break because of this. I expect to release this some time next week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1751 updated to v5 which ships with types. However, the
Longtype used here seems to be custom and not imported, so this was never used anyways?protobuf.js/index.d.ts
Lines 1848 to 1862 in 6f0806d