fix: invalid processing of leading and trailing comments#1593
Merged
alexander-fenster merged 3 commits intoprotobufjs:masterfrom May 8, 2021
Merged
fix: invalid processing of leading and trailing comments#1593alexander-fenster merged 3 commits intoprotobufjs:masterfrom
alexander-fenster merged 3 commits intoprotobufjs:masterfrom
Conversation
…r field with trailing comment
Contributor
Author
|
Alexander Gennadievich (@alexander-fenster), could you help with review? 🙂 |
Contributor
|
Hi @ykolbin, nice to see you here :) Sure, we'll take care of this on our next review meeting within a week or so (it will require some staring in the code to figure out what's going on). |
alexander-fenster
approved these changes
May 7, 2021
This was referenced Jul 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with preferred trailing comment processing (preferTrailingComment = true), if the next field contains a leading comment.
Actual Result:
field1.comment = "Field with both comments"
field2.comment = "field2 trailing comment"
Expected Result:
field1.comment = "field1 trailing comment"
field2.comment = "field2 trailing comment"