fix!: encoding of empty Buffers#1514
Merged
bcoe merged 2 commits intoprotobufjs:masterfrom Dec 7, 2020
Merged
Conversation
alexander-fenster
changed the title
alexander-fenster
approved these changes
Dec 4, 2020
Contributor
alexander-fenster
left a comment
alexander-fenster
left a comment
There was a problem hiding this comment.
We talked a little bit and decided it's a breaking change and should go to v7.0 which hopefully will be released soon enough.
Contributor
Author
|
Thanks for the update @alexander-fenster. I think it's definitely safer to release this in a major version as there might be users relying on the current behavior. |
This was referenced Dec 7, 2020
This was referenced Jul 7, 2022
This was referenced Jul 8, 2022
Merged
This was referenced Oct 18, 2022
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1500
fixes #885
The fix is from @jawid-h in #1500. Thanks to him.
I added tests.
Note the change in behavior:
The default value for an empty
Bufferis now a Buffer of length 0 vs an empty array before.I have not included the generated files in this CL (
dist/*andindex.d.ts).Please let me know if they should be there and I'll add them.