fix: fix util.global#1444
Closed
starkwang wants to merge 1 commit intoprotobufjs:masterfrom
Closed
Conversation
Good job, my project works fine after applied your changes. |
Merged
Member
|
This PR just moves the problem from one place to another, in that it now identifies any top-level variable named Please see the discussion in #1441. If you'd like to help, please test the latest fix proposed there and let us know whether it does or does not work in your (to-be-identified-as node) environment. |
Author
|
Closed due to #1445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1443