Skip to content

feat: valuesOptions for enums#1358

Merged
alexander-fenster merged 8 commits intoprotobufjs:masterfrom
batsuev:master
Aug 17, 2022
Merged

feat: valuesOptions for enums#1358
alexander-fenster merged 8 commits intoprotobufjs:masterfrom
batsuev:master

Conversation

@batsuev
Copy link
Copy Markdown
Contributor

@batsuev batsuev commented Feb 11, 2020

No description provided.

@batsuev batsuev requested a review from dcodeIO February 15, 2020 08:40
@alexander-fenster alexander-fenster changed the title valuesOptions for enums feat: valuesOptions for enums Jul 10, 2020
@alexander-fenster
Copy link
Copy Markdown
Contributor

@batsuev Can you please make sure the test passes?

Error: .end() already called: should parse correctly in enum

With the green CI we'll be happy to merge this one.

Thank you!

@XeniaSiskaki
Copy link
Copy Markdown

Are there any plans of fixing and merging this request?

@jeffjose
Copy link
Copy Markdown

Stumbled on this, and would like to see this merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants