Allow Windows unc paths to be resolved and normalized#1351
Merged
alexander-fenster merged 4 commits intoprotobufjs:masterfrom Jun 25, 2020
HTempest:windows-unc-path
Merged
Allow Windows unc paths to be resolved and normalized#1351alexander-fenster merged 4 commits intoprotobufjs:masterfrom HTempest:windows-unc-path
alexander-fenster merged 4 commits intoprotobufjs:masterfrom
HTempest:windows-unc-path
Conversation
dcodeIO
approved these changes
Feb 4, 2020
Contributor
|
@TomWilloughby Can you please update the branch to the latest master to re-run the CI? |
Contributor
Author
|
@alexander-fenster I've merged the latest master and made sure the CI passes. Sorry it took so long, I haven't been checking this account since lockdown started. |
alexander-fenster
approved these changes
Jun 25, 2020
Contributor
|
Thank you @TomWilloughby! |
taylorcode
pushed a commit
to taylorcode/protobuf.js
that referenced
this pull request
Oct 16, 2020
…s#1351) * Add unc paths to isAbsolute regex * Allow unc paths to be resolved and normalized * Remove trailing whitespace
This was referenced May 20, 2022
Merged
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1346