Issue 1275 - Upgrade jsdoc#1338
Closed
chris-grabcad wants to merge 1 commit intoprotobufjs:masterfrom
Closed
Conversation
fixes issues with using pbts on Windows platforms with modern versionf of node 12.0.0 +
Member
|
Thanks, sounds good. Preferring updating jsdoc over the other options, but I'm too paranoid to merge package-lock changes. Currently looking into upgrading ALL the dependencies, and seeing how that turns out. |
Author
|
Ok - thanks for fixing ... I will look out for an updated version so I can stop using our local fork 👍 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issues with using pbts on Windows platforms
with modern versions of node 12.0.0 +
I have tried this locally on the project I work on with node 12.0.0 and it fixes problems as described here
#1275 (comment)