fix: Import Long types#1166
fix: Import Long types#1166JustinBeckwith merged 1 commit intoprotobufjs:masterfrom ffflorian:patch-1
Conversation
|
@dcodeIO what do you think? |
|
@dcodeIO @JustinBeckwith any update on this? |
|
When one actually tries to release a version of this package (which hasn't happened since this PR was merged), one presumably runs This causes the I think the solution is to remove the "Any compatible Long instance" jsdoc block from src/util/minimal.js. |
|
While working on #1356 I noticed several problems with this as well, and I'm considering to revert the changes made in this PR there. The intended process of working with proper |
Longis implicitly loaded as dependency. If that fails for some reason,Longwill be undefined.This PR makes sure that the types for
Longare always in place.