* support default value for map key & value#1087
Closed
shrimpz wants to merge 1 commit intoprotobufjs:masterfrom
Closed
* support default value for map key & value#1087shrimpz wants to merge 1 commit intoprotobufjs:masterfrom
shrimpz wants to merge 1 commit intoprotobufjs:masterfrom
Conversation
Contributor
|
@shrimpz I don't feel I really understand the code changes; can you please add some tests that show what exactly the changed code will do? Thanks! |
|
@shrimpz (cc: @alexander-fenster) - I'm also stuck by the issue that your pull request fixes. Do you know what happened to it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message TestMap
{
map<int32, int32> x = 1;
}
tm.x[0] = 10;
tm.x[10] = 0;