Allow empty statements#1051
Closed
benesch wants to merge 1 commit intoprotobufjs:masterfrom
Closed
Conversation
The protobuf language specification [0] allows empty statements to
appear in several places. For example, the following protobuf is
well-formed and is accepted by protoc, but was previously rejected by
pbjs:
message A {
string a = 1;;
}
Support empty statements by ignoring them.
[0]: https://developers.google.com/protocol-buffers/docs/reference/proto2-spec#message_definition
Contributor
|
Should probably add tests to make sure empty statements don't occur in places they shouldn't: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protobuf language specification (0) allows empty statements to
appear in several places. For example, the following protobuf is
well-formed and is accepted by protoc, but was previously rejected by
pbjs:
Support empty statements by ignoring them.