Skip to content

--target static-module --es6 --wrap es6 produces a code that fails to run #1929

@tkafka

Description

@tkafka

protobuf.js version: 7.2.5

Repro steps:

./node_modules/.bin/pbjs --target static-module --es6 --wrap es6 ./my-app.proto > ./js/my-app.js

Expected behavior:
The generated code build and runs.

Actual behavior:
Running the code results in error:

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '<...>/node_modules/protobufjs/minimal' imported from <...>/protobuf/js/my-app.js

I need to replace

import * as $protobuf from "protobufjs/minimal"

// Common aliases
const $Reader = $protobuf.Reader, 
	$Writer = $protobuf.Writer,
	$util = $protobuf.util

// Exported root namespace
const $root = $protobuf.roots["default"] || ($protobuf.roots["default"] = {})

for

import * as $protobuf from "protobufjs/minimal.js"; // added .js

// Common aliases
const $Reader = $protobuf.default.Reader, // replaced $protobuf with $protobuf.default
	$Writer = $protobuf.default.Writer,
	$util = $protobuf.default.util

// Exported root namespace
const $root = $protobuf.default.roots || ($protobuf.default.roots = {}) // replaced $protobuf.roots["default"] with $protobuf.default.roots

... in order to make the generated module runnable.

Possible related: #1862

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions