fix(types): update type deps (#1776)

thw0rted · alexander-fenster · web-flow · commit d87978b8eb2a · 2022-08-17T12:04:05.000-07:00
* Update type deps

Remove duplicate `long` types

* Fix type tests

Co-authored-by: Alexander Fenster &lt;fenster@google.com&gt;
diff --git a/cli/pbts.js b/cli/pbts.js
@@ -144,7 +144,7 @@ exports.main = function(args, callback) {
             var output = [];
             if (argv.main)
                 output.push(
-                    "// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run types'.",
+                    "// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run build:types'.",
                     ""
                 );
             if (argv.global)
diff --git a/index.d.ts b/index.d.ts
@@ -1,4 +1,4 @@
-// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run types'.
+// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run build:types'.
 
 export as namespace protobuf;
 
diff --git a/tests/README.md b/tests/README.md
@@ -5,7 +5,7 @@ It is essential that tests only use the cross-platform API that is also availabl
 * Use `load`, not `loadSync`
 * Use `Reader.create`, not `BufferReader`
 * Use `Writer.create`, not `BufferWriter`
-* It is safe to use `Long`
+* It is safe to use `Long`, but TypeScript tests must import the type from `"long"`
 
 If it's absolutely inevitable for your test case to use node-specific features, you can still use this pattern:
 
diff --git a/tests/data/mapbox/vector_tile.d.ts b/tests/data/mapbox/vector_tile.d.ts
@@ -1,4 +1,6 @@
 import * as $protobuf from "../../..";
+import Long from "long";
+
 export namespace vector_tile {
 
     interface ITile {
diff --git a/tsconfig.json b/tsconfig.json
@@ -2,6 +2,7 @@
     "compilerOptions": {
         "target": "ES5",
         "experimentalDecorators": true,
-        "emitDecoratorMetadata": true
+        "emitDecoratorMetadata": true,
+        "esModuleInterop": true,
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run types'.`
	`1`	`+// DO NOT EDIT! This is a generated file. Edit the JSDoc in src/*.js instead and run 'npm run build:types'.`
`2`	`2`
`3`	`3`	`export as namespace protobuf;`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`"compilerOptions": {`
`3`	`3`	`"target": "ES5",`
`4`	`4`	`"experimentalDecorators": true,`
`5`		`- "emitDecoratorMetadata": true`
	`5`	`+ "emitDecoratorMetadata": true,`
	`6`	`+ "esModuleInterop": true,`
`6`	`7`	`}`
`7`	`8`	`}`