Other: More precise linter configuration

dcodeIO · dcodeIO · commit a7ab1036906b · 2017-03-04T05:22:49.000+01:00
diff --git a/.codeclimate.yml b/.codeclimate.yml
@@ -4,4 +4,12 @@ engines:
 ratings:
   paths:
   - "src/**.js"
-exclude_paths:
+  - "lib/aspromise/**.js"
+  - "lib/base64/**.js"
+  - "lib/eventemitter/**.js"
+  - "lib/fetch/**.js"
+  - "lib/inquire/**.js"
+  - "lib/path/**.js"
+  - "lib/pool/**.js"
+  - "lib/utf8/**.js"
+exclude_paths:
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1,15 @@
+bench/*
+bin/*
+cli/*
+coverage/*
+dist/*
+docs/*
+gulpfile.js
+lib/deep-equal/*
+lib/prelude.js
+lib/polyfill.js
+lib/tape-adapter.js
+lib/tsd-jsdoc/*
+sandbox/*
+scripts/*
+**/tests/*
diff --git a/.travis.yml b/.travis.yml
@@ -14,6 +14,8 @@ addons:
   apt:
     sources: ubuntu-toolchain-r-test
     packages: g++-4.8
+  code_climate:
+    repo_token: 20d88c0ad0ae53be53f48ef57cfec8ff6d8fc86381f742b50747335f3cebdc69
 
 matrix:
   include:
diff --git a/bench/prof.js b/bench/prof.js
@@ -21,7 +21,7 @@ if (process.execArgv.indexOf("--prof") < 0) {
             fs.unlink(file);
     });
     process.stdout.write("generating profile (may take a while) ...\n");
-    child_process.execSync("node --prof --trace-deopt " + process.execArgv.join(" ") + " " + process.argv.slice(1).join(' '), {
+    child_process.execSync("node --prof --trace-deopt " + process.execArgv.join(" ") + " " + process.argv.slice(1).join(" "), {
         cwd: process.cwd(),
         stdio: "inherit"
     });
diff --git a/bench/read.js b/bench/read.js
@@ -120,7 +120,7 @@ function readString(bytes) {
         readString(array);
     })
     .add("readString buffer", function() {
-        readString(buffer)
+        readString(buffer);
     })
     .add("toString buffer", function() {
         buffer.toString("utf8", 0, buffer.length);
diff --git a/bench/suite.js b/bench/suite.js
@@ -27,7 +27,7 @@ function newSuite(name) {
                 if (fastest.indexOf(bench) === 0)
                     return;
                 var hz = hz = getHz(bench);
-                var percent = (1 - (hz / fastestHz)) * 100;
+                var percent = (1 - hz / fastestHz) * 100;
                 process.stdout.write(chalk.white(pad(bench.name, padSize)) + " was " + chalk.red(percent.toFixed(1) + "% slower") + "\n");
             });
         }
diff --git a/bench/write.js b/bench/write.js
@@ -178,13 +178,13 @@ buffer = new Buffer(1000);
         writeString(array, 0, str);
     })
     .add("writeString buffer", function() {
-        writeString(buffer, 0, str)
+        writeString(buffer, 0, str);
     })
     .add("write buffer", function() {
-        buffer.write(str, 0)
+        buffer.write(str, 0);
     })
     .add("utf8Write buffer", function() {
-        buffer.utf8Write(str, 0)
+        buffer.utf8Write(str, 0);
     })
     /* .add("byteLength array", function() {
         byteLength(str)
diff --git a/debug.js b/debug.js
@@ -1 +1,2 @@
+"use strict";
 module.exports = require("./src/index-debug");
diff --git a/examples/streaming-rpc.js b/examples/streaming-rpc.js
@@ -10,9 +10,9 @@ var root = protobuf.Root.fromJSON({
         Greeter: {
             methods: {
                 "SayHello": {
-                    requestType: 'Hello',
+                    requestType: "Hello",
                     requestStream: true,
-                    responseType: 'World',
+                    responseType: "World",
                     responseStream: true
                 }
             }
diff --git a/light.js b/light.js
@@ -1 +1,2 @@
+"use strict";
 module.exports = require("./src/index-light");
diff --git a/minimal.js b/minimal.js
@@ -1 +1,2 @@
+"use strict";
 module.exports = require("./src/index-minimal");
diff --git a/package.json b/package.json
@@ -30,7 +30,7 @@
     "coverage": "istanbul cover node_modules/tape/bin/tape tests/*.js tests/node/*.js",
     "coverage-ci": "npm run coverage && cat coverage/lcov.info | coveralls",
     "docs": "jsdoc -c jsdoc.docs.json -R README.md --verbose --pedantic",
-    "lint": "eslint src",
+    "lint": "eslint **/*.js",
     "pages": "node scripts/pages",
     "prepublish": "node scripts/prepublish",
     "postinstall": "node scripts/postinstall",
@@ -65,7 +65,7 @@
     "bundle-collapser": "^1.2.1",
     "chalk": "^1.1.3",
     "escodegen": "^1.8.1",
-    "eslint": "^3.16.1",
+    "eslint": "^3.17.0",
     "espree": "^3.1.3",
     "estraverse": "^4.2.0",
     "gh-pages": "^0.12.0",
@@ -87,7 +87,7 @@
     "tape": "^4.6.3",
     "tmp": "0.0.31",
     "typescript": "^2.2.1",
-    "uglify-js": "^2.8.4",
+    "uglify-js": "^2.8.5",
     "vinyl-buffer": "^1.0.0",
     "vinyl-fs": "^2.4.4",
     "vinyl-source-stream": "^1.1.0"
diff --git a/runtime.js b/runtime.js
@@ -1,2 +1,3 @@
 // deprecated - compatibility layer for v6.5 and earlier
+"use strict";
 module.exports = require("./minimal");
diff --git a/tests/other_package.js b/tests/other_package.js
@@ -1,3 +1,4 @@
+"use strict";
 var tape = require("tape");
 
 var protobuf = require(".."),
@@ -8,8 +9,10 @@ tape.test("package.json (reflected)", function(test) {
     test.plan(2);
 
     protobuf.load("tests/data/package.proto", function(err, root) {
-        if (err)
-            return test.fail(err.message);
+        if (err) {
+            test.fail(err.message);
+            return;
+        }
         
         var Package = root.lookup("Package"),
             Repository = root.lookup("Package.Repository");

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ function newSuite(name) {`
`27`	`27`	`if (fastest.indexOf(bench) === 0)`
`28`	`28`	`return;`
`29`	`29`	`var hz = hz = getHz(bench);`
`30`		`- var percent = (1 - (hz / fastestHz)) * 100;`
	`30`	`+ var percent = (1 - hz / fastestHz) * 100;`
`31`	`31`	`process.stdout.write(chalk.white(pad(bench.name, padSize)) + " was " + chalk.red(percent.toFixed(1) + "% slower") + "\n");`
`32`	`32`	`});`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+"use strict";`
`1`	`2`	`module.exports = require("./src/index-debug");`
Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,9 @@ var root = protobuf.Root.fromJSON({`
`10`	`10`	`Greeter: {`
`11`	`11`	`methods: {`
`12`	`12`	`"SayHello": {`
`13`		`- requestType: 'Hello',`
	`13`	`+ requestType: "Hello",`
`14`	`14`	`requestStream: true,`
`15`		`- responseType: 'World',`
	`15`	`+ responseType: "World",`
`16`	`16`	`responseStream: true`
`17`	`17`	`}`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+"use strict";`
`1`	`2`	`module.exports = require("./src/index-light");`