fix: Parse empty repeated options (#2161)

dcodeIO · web-flow · commit 8c5060f3cf42 · 2026-04-27T23:10:45.000+02:00
diff --git a/src/parse.js b/src/parse.js
@@ -765,13 +765,15 @@ function parse(source, root, options) {
                     value = [];
                     var lastValue;
                     if (skip("[", true)) {
-                        do {
-                            lastValue = readValue(true);
-                            value.push(lastValue);
-                        } while (skip(",", true));
-                        skip("]");
-                        if (typeof lastValue !== "undefined") {
-                            setOption(parent, name + "." + token, lastValue);
+                        if (!skip("]", true)) {
+                            do {
+                                lastValue = readValue(true);
+                                value.push(lastValue);
+                            } while (skip(",", true));
+                            skip("]");
+                            if (typeof lastValue !== "undefined") {
+                                setOption(parent, name + "." + token, lastValue);
+                            }
                         }
                     }
                 } else {
diff --git a/tests/comp_options-parse.js b/tests/comp_options-parse.js
@@ -134,6 +134,7 @@ tape.test("Options", function (test) {
             {
                 "(method_rep_msg)": {
                     value: 1,
+                    empty_repeated: [],
                     nested: {nested: {value: "x"}},
                     rep_nested: [{value: "y"}, {value: "z"}],
                     rep_value: 3
@@ -149,6 +150,7 @@ tape.test("Options", function (test) {
         ];
 
         test.same(TestOptionsRpc.parsedOptions, expectedParsedOptions, "should correctly parse all nested message options");
+        test.equal(TestOptionsRpc.options["(method_rep_msg).empty_repeated"], undefined, "should not set a last value for empty repeated options");
         var jsonTestOptionsRpc = TestOptionsRpc.toJSON();
         test.same(jsonTestOptionsRpc.parsedOptions, expectedParsedOptions, "should correctly store all nested method options in JSON");
         var rootFromJson = protobuf.Root.fromJSON(root.toJSON());
diff --git a/tests/data/options_test.proto b/tests/data/options_test.proto
@@ -119,6 +119,7 @@ service TestOptionsService {
     rpc TestOptionsRpc(Msg) returns (Msg) {
         option (method_rep_msg) = {
             value: 1
+            empty_repeated: []
             nested {
                 nested {
                     value: "x"
