|
| 1 | +using ProtoBuf.Meta; |
| 2 | +using System.Reflection; |
| 3 | +using Xunit; |
| 4 | + |
| 5 | +namespace ProtoBuf.Test.Issues |
| 6 | +{ |
| 7 | + public class Issue1102 |
| 8 | + { |
| 9 | + |
| 10 | + [Fact] |
| 11 | + public void TestEnumOrderWithNegativesAndOutOfRangeValues() |
| 12 | + { |
| 13 | + var model = RuntimeTypeModel.Create(); |
| 14 | + model.UseImplicitZeroDefaults = false; |
| 15 | + |
| 16 | + string proto = model.GetSchema(typeof(HazOutOfRangeAndNegatives), ProtoSyntax.Proto3); |
| 17 | + |
| 18 | + Assert.Equal(@"syntax = ""proto3""; |
| 19 | +package ProtoBuf.Test.Issues; |
| 20 | +
|
| 21 | +message HazOutOfRangeAndNegatives { |
| 22 | + int64 OutOfRange = 1; // declared as invalid enum: OutOfRangeEnum |
| 23 | + InRangeEnum InRange = 2; |
| 24 | +} |
| 25 | +enum InRangeEnum { |
| 26 | + ZERO = 0; // proto3 requires a zero value as the first item (it can be named anything) |
| 27 | + A = 1; |
| 28 | + C = 2147483647; |
| 29 | + E = -2147483647; |
| 30 | + B = -4; |
| 31 | +} |
| 32 | +/* for context only |
| 33 | +enum OutOfRangeEnum { |
| 34 | + ZERO = 0; // proto3 requires a zero value as the first item (it can be named anything) |
| 35 | + A = 1; |
| 36 | + C = 2147483647; |
| 37 | + E = -2147483647; |
| 38 | + B = -4; |
| 39 | + // D = 2147483648; // note: enums should be valid 32-bit integers |
| 40 | + // F = -2147483649; // note: enums should be valid 32-bit integers |
| 41 | +} |
| 42 | +*/ |
| 43 | +", proto, ignoreLineEndingDifferences: true); |
| 44 | + } |
| 45 | + |
| 46 | + public enum InRangeEnum : long |
| 47 | + { |
| 48 | + A = 1, |
| 49 | + B = -4, |
| 50 | + C = int.MaxValue, |
| 51 | + E = -int.MaxValue, |
| 52 | + } |
| 53 | + |
| 54 | + public enum OutOfRangeEnum : long |
| 55 | + { |
| 56 | + A = 1, |
| 57 | + B = -4, |
| 58 | + C = int.MaxValue, |
| 59 | + D = ((long)int.MaxValue) + 1, |
| 60 | + E = -int.MaxValue, |
| 61 | + F = ((long)int.MinValue) - 1, |
| 62 | + } |
| 63 | + |
| 64 | + [ProtoContract] |
| 65 | + public class HazOutOfRangeAndNegatives |
| 66 | + { |
| 67 | + [ProtoMember(1)] |
| 68 | + public OutOfRangeEnum OutOfRange { get; set; } |
| 69 | + |
| 70 | + [ProtoMember(2)] |
| 71 | + public InRangeEnum InRange { get; set; } |
| 72 | + } |
| 73 | + |
| 74 | + |
| 75 | + [Fact] |
| 76 | + public void TestEnumOrderInProtoMatchesDefinitionOrder() |
| 77 | + { |
| 78 | + var letters = new string[] { "A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q", "R", "S", "T", "U", "V", "W", "X", "Y", "Z"}; |
| 79 | + |
| 80 | + MemberInfo[] foundList = typeof(FooEnum).GetMembers(BindingFlags.Public | BindingFlags.Static); |
| 81 | + |
| 82 | + Assert.Equal(letters.Length, foundList.Length); |
| 83 | + |
| 84 | + for (var i = 0; i < foundList.Length; i++) |
| 85 | + { |
| 86 | + var field = (FieldInfo)foundList[i]; |
| 87 | + Assert.Equal(letters[i], field.Name); |
| 88 | + } |
| 89 | + |
| 90 | + var proto = Serializer.GetProto<FooEnum>(); |
| 91 | + |
| 92 | + Assert.Equal(ExpectedOutput, proto, ignoreLineEndingDifferences: true); |
| 93 | + } |
| 94 | + |
| 95 | + private static string ExpectedOutput = @"syntax = ""proto3""; |
| 96 | +package ProtoBuf.Test.Issues; |
| 97 | +
|
| 98 | +enum FooEnum { |
| 99 | + A = 0; |
| 100 | + B = 1; |
| 101 | + C = 2; |
| 102 | + D = 3; |
| 103 | + E = 4; |
| 104 | + F = 5; |
| 105 | + G = 6; |
| 106 | + H = 7; |
| 107 | + I = 8; |
| 108 | + J = 9; |
| 109 | + K = 10; |
| 110 | + L = 11; |
| 111 | + M = 12; |
| 112 | + N = 13; |
| 113 | + O = 14; |
| 114 | + P = 15; |
| 115 | + Q = 16; |
| 116 | + R = 17; |
| 117 | + S = 18; |
| 118 | + T = 19; |
| 119 | + U = 20; |
| 120 | + V = 21; |
| 121 | + W = 22; |
| 122 | + X = 23; |
| 123 | + Y = 24; |
| 124 | + Z = 25; |
| 125 | +} |
| 126 | +"; |
| 127 | + |
| 128 | + [ProtoContract] |
| 129 | + public enum FooEnum |
| 130 | + { |
| 131 | + [ProtoEnum] |
| 132 | + A, |
| 133 | + [ProtoEnum] |
| 134 | + B, |
| 135 | + [ProtoEnum] |
| 136 | + C, |
| 137 | + [ProtoEnum] |
| 138 | + D, |
| 139 | + [ProtoEnum] |
| 140 | + E, |
| 141 | + [ProtoEnum] |
| 142 | + F, |
| 143 | + [ProtoEnum] |
| 144 | + G, |
| 145 | + [ProtoEnum] |
| 146 | + H, |
| 147 | + [ProtoEnum] |
| 148 | + I, |
| 149 | + [ProtoEnum] |
| 150 | + J, |
| 151 | + [ProtoEnum] |
| 152 | + K, |
| 153 | + [ProtoEnum] |
| 154 | + L, |
| 155 | + [ProtoEnum] |
| 156 | + M, |
| 157 | + [ProtoEnum] |
| 158 | + N, |
| 159 | + [ProtoEnum] |
| 160 | + O, |
| 161 | + [ProtoEnum] |
| 162 | + P, |
| 163 | + [ProtoEnum] |
| 164 | + Q, |
| 165 | + [ProtoEnum] |
| 166 | + R, |
| 167 | + [ProtoEnum] |
| 168 | + S, |
| 169 | + [ProtoEnum] |
| 170 | + T, |
| 171 | + [ProtoEnum] |
| 172 | + U, |
| 173 | + [ProtoEnum] |
| 174 | + V, |
| 175 | + [ProtoEnum] |
| 176 | + W, |
| 177 | + [ProtoEnum] |
| 178 | + X, |
| 179 | + [ProtoEnum] |
| 180 | + Y, |
| 181 | + [ProtoEnum] |
| 182 | + Z |
| 183 | + } |
| 184 | + } |
| 185 | +} |
0 commit comments