chore: fix changeset ignore config by ocavue · Pull Request #984 · prosekit/prosekit

ocavue · 2025-04-18T10:05:05Z

Summary by CodeRabbit

Chores
- Updated configuration to include @prosekit/dev in changeset processing, ensuring it is no longer ignored.

changeset-bot · 2025-04-18T10:05:10Z

⚠️ No Changeset found

Latest commit: 3206921

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-04-18T10:05:12Z

Walkthrough

This update modifies the logic for generating the .changeset/config.json file, specifically determining which packages are included or ignored in the changeset process. The approach now uses a new helper function to gather all public packages and their transitive dependencies, ensuring that only private packages not reachable from public packages are ignored. The configuration file was updated accordingly, removing @prosekit/dev from the ignore list. No changes were made to exported or public entities except for the addition of the new helper function.

Changes

File(s)	Change Summary
.changeset/config.json	Removed `@prosekit/dev` from the list of ignored packages in the changeset configuration.
packages/dev/src/gen-changeset-config-json.ts	Replaced direct dependency gathering with a new helper, `getVisiblePackages`, to collect all public packages and their transitive dependencies. Updated filtering logic for the ignore list. Added import for `isPublicPackage`. Introduced the new `getVisiblePackages` function.

Sequence Diagram(s)

sequenceDiagram
    participant DevScript as genChangesetConfigJson
    participant VFS as vfs
    participant ConfigFile as .changeset/config.json

    DevScript->>VFS: getPublicPackages()
    DevScript->>VFS: getAllPackages()
    DevScript->>DevScript: getVisiblePackages() (public + transitive deps)
    DevScript->>ConfigFile: Write ignore list (private packages not in visible set)

Possibly related PRs

chore: fix changeset ignore config #983: Both PRs modify the logic in genChangesetConfigJson to dynamically determine which private packages to exclude from the changeset ignore list based on their dependency relationship with public packages, refining the filtering criteria for the ignore configuration.

Poem

A hop, a skip, a config tweak,
Now changesets see what they seek.
No longer hidden, dev hops in view,
Dependencies gathered, old logic adieu!
With a whisk of code and a bunny's delight,
The ignore list is trimmed just right.
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 478940c and 3206921.

📒 Files selected for processing (2)

.changeset/config.json (0 hunks)
packages/dev/src/gen-changeset-config-json.ts (1 hunks)

💤 Files with no reviewable changes (1)

.changeset/config.json

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: test-e2e (3)
GitHub Check: deploy
GitHub Check: test-e2e (2)
GitHub Check: test-e2e (1)
GitHub Check: size

🔇 Additional comments (3)

packages/dev/src/gen-changeset-config-json.ts (3)

1-1: Added appropriate import for new functionality

The import of isPublicPackage is correctly added to support the new package traversal functionality.

6-6: Good refactoring to use the helper function

The refactoring to use getVisiblePackages() and filter based on its results improves the code organization and makes the logic more explicit. This change ensures that all packages reachable from public packages (including transitive dependencies) are excluded from the ignore list.

Also applies to: 10-10

19-50: 🛠️ Refactor suggestion

Implementation issue in breadth-first traversal

The comment describes a breadth-first traversal, but the implementation uses queue.pop() which takes from the end of the array, making it a depth-first search instead.
- const name = queue.pop()
+ const name = queue.shift()
Additionally, the public packages themselves should be added to the seen set at initialization:
  const seen = new Set<string>()
  const queue: string[] = packages.filter(isPublicPackage).map((pkg) => pkg.packageJson.name)
+ // Add public packages to seen set
+ for (const name of queue) {
+   seen.add(name)
+ }
Otherwise, the function correctly builds a dependency graph and traverses it to find all packages visible to public packages.

Likely an incorrect or invalid review comment.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-04-18T10:07:28Z

Open in StackBlitz

@prosekit/basic

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/basic@984

@prosekit/core

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/core@984

@prosekit/lit

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/lit@984

@prosekit/extensions

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/extensions@984

@prosekit/pm

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/pm@984

@prosekit/preact

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/preact@984

prosekit

npm i https://pkg.pr.new/prosekit/prosekit@984

@prosekit/react

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/react@984

@prosekit/solid

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/solid@984

@prosekit/svelte

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/svelte@984

@prosekit/vue

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/vue@984

@prosekit/web

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/web@984

commit: 3206921

github-actions · 2025-04-18T10:08:06Z

size-limit report 📦

Path	Size
prosekit/basic	65.84 KB (0%)
prosekit/basic/style.css	1018 B (0%)
prosekit/basic/typography.css	666 B (0%)
prosekit/core	62.2 KB (0%)
prosekit/core/test	51.06 KB (0%)
prosekit/extensions	13 B (0%)
prosekit/extensions/autocomplete	28.98 KB (0%)
prosekit/extensions/blockquote	21.41 KB (0%)
prosekit/extensions/bold	21.63 KB (0%)
prosekit/extensions/code	21.55 KB (0%)
prosekit/extensions/code-block	1.05 MB (0%)
prosekit/extensions/commit	31.56 KB (0%)
prosekit/extensions/commit/style.css	60 B (0%)
prosekit/extensions/doc	10.5 KB (0%)
prosekit/extensions/drop-cursor	14.73 KB (0%)
prosekit/extensions/enter-rule	15.14 KB (0%)
prosekit/extensions/file	14.42 KB (0%)
prosekit/extensions/gap-cursor	30.1 KB (0%)
prosekit/extensions/gap-cursor/style.css	149 B (0%)
prosekit/extensions/heading	21.72 KB (0%)
prosekit/extensions/horizontal-rule	15.71 KB (0%)
prosekit/extensions/image	14.98 KB (0%)
prosekit/extensions/input-rule	15.08 KB (0%)
prosekit/extensions/italic	21.58 KB (0%)
prosekit/extensions/link	25.66 KB (0%)
prosekit/extensions/list	40.91 KB (0%)
prosekit/extensions/list/style.css	450 B (0%)
prosekit/extensions/loro	19.27 KB (0%)
prosekit/extensions/loro/style.css	181 B (0%)
prosekit/extensions/mark-rule	14.43 KB (0%)
prosekit/extensions/mention	14.93 KB (0%)
prosekit/extensions/mod-click-prevention	13.84 KB (0%)
prosekit/extensions/paragraph	20.22 KB (0%)
prosekit/extensions/placeholder	33.01 KB (0%)
prosekit/extensions/placeholder/style.css	61 B (0%)
prosekit/extensions/readonly	13.76 KB (0%)
prosekit/extensions/search	30.45 KB (0%)
prosekit/extensions/search/style.css	117 B (0%)
prosekit/extensions/strike	21.61 KB (0%)
prosekit/extensions/table	44.84 KB (0%)
prosekit/extensions/table/style.css	241 B (0%)
prosekit/extensions/text	10.5 KB (0%)
prosekit/extensions/text-align	20.24 KB (0%)
prosekit/extensions/underline	20.6 KB (0%)
prosekit/extensions/virtual-selection	28.52 KB (0%)
prosekit/extensions/virtual-selection/style.css	64 B (0%)
prosekit/extensions/yjs	19.49 KB (0%)
prosekit/extensions/yjs/style.css	192 B (0%)
prosekit/lit	13 B (0%)
prosekit/lit/autocomplete	46.76 KB (0%)
prosekit/lit/block-handle	26.57 KB (0%)
prosekit/lit/inline-popover	30 KB (0%)
prosekit/lit/popover	14.07 KB (0%)
prosekit/lit/resizable	4.03 KB (0%)
prosekit/lit/table-handle	34.77 KB (0%)
prosekit/lit/tooltip	11.41 KB (0%)
prosekit/pm	13 B (0%)
prosekit/pm/commands	15.84 KB (0%)
prosekit/pm/history	13.55 KB (0%)
prosekit/pm/inputrules	11.8 KB (0%)
prosekit/pm/keymap	11.72 KB (0%)
prosekit/pm/model	12.71 KB (0%)
prosekit/pm/state	16.8 KB (0%)
prosekit/pm/transform	14.62 KB (0%)
prosekit/pm/view	39.91 KB (0%)
prosekit/pm/view/style/prosemirror.css	259 B (0%)
prosekit/preact	19.57 KB (0%)
prosekit/preact/autocomplete	47.41 KB (0%)
prosekit/preact/block-handle	27.22 KB (0%)
prosekit/preact/inline-popover	30.54 KB (0%)
prosekit/preact/popover	14.62 KB (0%)
prosekit/preact/resizable	4.63 KB (0%)
prosekit/preact/table-handle	35.41 KB (0%)
prosekit/preact/tooltip	11.97 KB (0%)
prosekit/react	36.51 KB (0%)
prosekit/react/autocomplete	47.34 KB (0%)
prosekit/react/block-handle	27.11 KB (0%)
prosekit/react/inline-popover	30.51 KB (0%)
prosekit/react/popover	14.62 KB (0%)
prosekit/react/resizable	4.64 KB (0%)
prosekit/react/table-handle	35.36 KB (0%)
prosekit/react/tooltip	11.94 KB (0%)
prosekit/solid	39.69 KB (0%)
prosekit/solid/autocomplete	47.3 KB (0%)
prosekit/solid/block-handle	27.09 KB (0%)
prosekit/solid/inline-popover	30.51 KB (0%)
prosekit/solid/popover	14.57 KB (0%)
prosekit/solid/resizable	4.56 KB (0%)
prosekit/solid/table-handle	35.34 KB (0%)
prosekit/solid/tooltip	11.91 KB (0%)
prosekit/vue	36.58 KB (0%)
prosekit/vue/autocomplete	47.26 KB (0%)
prosekit/vue/block-handle	27.05 KB (0%)
prosekit/vue/inline-popover	30.42 KB (0%)
prosekit/vue/popover	14.52 KB (0%)
prosekit/vue/resizable	4.47 KB (0%)
prosekit/vue/table-handle	35.25 KB (0%)
prosekit/vue/tooltip	11.8 KB (0%)
prosekit/web	13 B (0%)
prosekit/web/autocomplete	46.78 KB (0%)
prosekit/web/block-handle	26.54 KB (0%)
prosekit/web/inline-popover	30.02 KB (0%)
prosekit/web/popover	14.02 KB (0%)
prosekit/web/resizable	4.03 KB (0%)
prosekit/web/table-handle	34.79 KB (0%)
prosekit/web/tooltip	11.39 KB (0%)

chore: fix changeset ignore config

3206921

ocavue marked this pull request as ready for review April 18, 2025 10:06

github-actions bot deployed to prosekit-dev (Preview) April 18, 2025 10:07 View deployment

ocavue merged commit 0f81a4c into master Apr 18, 2025
15 checks passed

ocavue deleted the ocavue/changeset-config2 branch April 18, 2025 10:09

coderabbitai bot mentioned this pull request Apr 19, 2025

chore: use tsdown to bundle packages #980

Merged

coderabbitai bot mentioned this pull request Nov 26, 2025

chore: extract reusable vfs package #1346

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: fix changeset ignore config#984

chore: fix changeset ignore config#984
ocavue merged 1 commit intomasterfrom
ocavue/changeset-config2

ocavue commented Apr 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Apr 18, 2025

Uh oh!

coderabbitai bot commented Apr 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Apr 18, 2025

Uh oh!

github-actions bot commented Apr 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ocavue commented Apr 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Apr 18, 2025

Uh oh!

github-actions bot commented Apr 18, 2025

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ocavue commented Apr 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)