Skip to content

chore: fix changeset ignore config#983

Merged
ocavue merged 2 commits intomasterfrom
ocavue/changeset-config
Apr 18, 2025
Merged

chore: fix changeset ignore config#983
ocavue merged 2 commits intomasterfrom
ocavue/changeset-config

Conversation

@ocavue
Copy link
Copy Markdown
Collaborator

@ocavue ocavue commented Apr 18, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated configuration to use the latest schema version.
    • Adjusted the list of ignored packages for improved management.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f33acdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package "@prosekit/config-tsup" depends on the ignored package "@prosekit/dev", but "@prosekit/config-tsup" is not being ignored. Please add "@prosekit/config-tsup" to the `ignore` option.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 18, 2025 •
edited
Loading

Walkthrough

The updates modify the .changeset/config.json file and the logic for generating its "ignore" list. The configuration schema is upgraded, and the ignore list is updated to replace two specific package names with a single one. Additionally, the script responsible for generating this configuration now dynamically determines which private packages to ignore based on their usage as dependencies of public packages, ensuring that private packages required by public packages are not ignored.

Changes

File(s) Change Summary
.changeset/config.json Upgraded schema version; replaced two ignored packages with a single package in the "ignore" array.
packages/dev/src/gen-changeset-config-json.ts Refined logic for generating the ignore list: now excludes from ignore any private package used by a public package; removed hardcoded skip list.

Poem

In the warren of configs, a schema hops anew,
With smarter skips and logic, our ignore list grew.
Private bunnies helping public ones are now in the show,
While old names hop away, letting new ones glow.
With every leap in logic, our changeset’s more bright—
CodeRabbit’s paws keep everything right!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66b2c75 and f33acdc.

📒 Files selected for processing (2)
  • .changeset/config.json (2 hunks)
  • packages/dev/src/gen-changeset-config-json.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: deploy
  • GitHub Check: linkcheck
  • GitHub Check: test-e2e (1)
  • GitHub Check: test-e2e (3)
  • GitHub Check: build
  • GitHub Check: test-e2e (2)
  • GitHub Check: size
🔇 Additional comments (6)
packages/dev/src/gen-changeset-config-json.ts (4)

4-6: Improved package management approach

The code now fetches both private and public packages to determine ignore list, which is more dynamic and maintainable than previous hardcoded approach.

7-16: Well-designed dependency tracking logic

This new implementation correctly identifies packages that shouldn't be ignored by building a set of all dependencies used by public packages. The comment clearly explains the reasoning, and the implementation with nested loops is efficient and easy to understand.

18-20: Good filtering implementation

The filtering logic now intelligently excludes only private packages that aren't dependencies of public packages, which ensures proper change tracking for dependencies that matter to public releases.

25-25: LGTM

The assignment to json.ignore properly applies the newly generated ignore list.

.changeset/config.json (2)

2-2: Schema version updated appropriately

Updating to the newer schema version 3.1.1 is a good practice to stay current with the latest features and improvements.

11-11: Simplified ignore list

Replacing the two separate packages (@prosekit/config-tsup and @prosekit/config-vitest) with a single package (@prosekit/dev) aligns with the dynamically generated ignore list from the updated script logic.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ocavue ocavue marked this pull request as ready for review April 18, 2025 07:31
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 18, 2025 •
edited
Loading

Open in StackBlitz

@prosekit/basic

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/basic@983

@prosekit/core

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/core@983

@prosekit/lit

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/lit@983

@prosekit/extensions

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/extensions@983

@prosekit/pm

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/pm@983

@prosekit/preact

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/preact@983

prosekit

npm i https://pkg.pr.new/prosekit/prosekit@983

@prosekit/react

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/react@983

@prosekit/solid

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/solid@983

@prosekit/svelte

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/svelte@983

@prosekit/vue

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/vue@983

@prosekit/web

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/web@983

commit: f33acdc

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2025 •
edited
Loading

size-limit report 📦

Path Size
prosekit/basic 65.84 KB (0%)
prosekit/basic/style.css 1018 B (0%)
prosekit/basic/typography.css 666 B (0%)
prosekit/core 62.2 KB (0%)
prosekit/core/test 51.06 KB (0%)
prosekit/extensions 13 B (0%)
prosekit/extensions/autocomplete 28.98 KB (0%)
prosekit/extensions/blockquote 21.41 KB (0%)
prosekit/extensions/bold 21.63 KB (0%)
prosekit/extensions/code 21.55 KB (0%)
prosekit/extensions/code-block 1.05 MB (0%)
prosekit/extensions/commit 31.56 KB (0%)
prosekit/extensions/commit/style.css 60 B (0%)
prosekit/extensions/doc 10.5 KB (0%)
prosekit/extensions/drop-cursor 14.73 KB (0%)
prosekit/extensions/enter-rule 15.14 KB (0%)
prosekit/extensions/file 14.42 KB (0%)
prosekit/extensions/gap-cursor 30.1 KB (0%)
prosekit/extensions/gap-cursor/style.css 149 B (0%)
prosekit/extensions/heading 21.72 KB (0%)
prosekit/extensions/horizontal-rule 15.71 KB (0%)
prosekit/extensions/image 14.98 KB (0%)
prosekit/extensions/input-rule 15.08 KB (0%)
prosekit/extensions/italic 21.58 KB (0%)
prosekit/extensions/link 25.66 KB (0%)
prosekit/extensions/list 40.91 KB (0%)
prosekit/extensions/list/style.css 450 B (0%)
prosekit/extensions/loro 19.27 KB (0%)
prosekit/extensions/loro/style.css 181 B (0%)
prosekit/extensions/mark-rule 14.43 KB (0%)
prosekit/extensions/mention 14.93 KB (0%)
prosekit/extensions/mod-click-prevention 13.84 KB (0%)
prosekit/extensions/paragraph 20.22 KB (0%)
prosekit/extensions/placeholder 33.01 KB (0%)
prosekit/extensions/placeholder/style.css 61 B (0%)
prosekit/extensions/readonly 13.76 KB (0%)
prosekit/extensions/search 30.45 KB (0%)
prosekit/extensions/search/style.css 117 B (0%)
prosekit/extensions/strike 21.61 KB (0%)
prosekit/extensions/table 44.84 KB (0%)
prosekit/extensions/table/style.css 241 B (0%)
prosekit/extensions/text 10.5 KB (0%)
prosekit/extensions/text-align 20.24 KB (0%)
prosekit/extensions/underline 20.6 KB (0%)
prosekit/extensions/virtual-selection 28.52 KB (0%)
prosekit/extensions/virtual-selection/style.css 64 B (0%)
prosekit/extensions/yjs 19.49 KB (0%)
prosekit/extensions/yjs/style.css 192 B (0%)
prosekit/lit 13 B (0%)
prosekit/lit/autocomplete 46.76 KB (0%)
prosekit/lit/block-handle 26.57 KB (0%)
prosekit/lit/inline-popover 30 KB (0%)
prosekit/lit/popover 14.07 KB (0%)
prosekit/lit/resizable 4.03 KB (0%)
prosekit/lit/table-handle 34.77 KB (0%)
prosekit/lit/tooltip 11.41 KB (0%)
prosekit/pm 13 B (0%)
prosekit/pm/commands 15.84 KB (0%)
prosekit/pm/history 13.55 KB (0%)
prosekit/pm/inputrules 11.8 KB (0%)
prosekit/pm/keymap 11.72 KB (0%)
prosekit/pm/model 12.71 KB (0%)
prosekit/pm/state 16.8 KB (0%)
prosekit/pm/transform 14.62 KB (0%)
prosekit/pm/view 39.91 KB (0%)
prosekit/pm/view/style/prosemirror.css 259 B (0%)
prosekit/preact 19.57 KB (0%)
prosekit/preact/autocomplete 47.41 KB (0%)
prosekit/preact/block-handle 27.22 KB (0%)
prosekit/preact/inline-popover 30.54 KB (0%)
prosekit/preact/popover 14.62 KB (0%)
prosekit/preact/resizable 4.63 KB (0%)
prosekit/preact/table-handle 35.41 KB (0%)
prosekit/preact/tooltip 11.97 KB (0%)
prosekit/react 36.51 KB (0%)
prosekit/react/autocomplete 47.34 KB (0%)
prosekit/react/block-handle 27.11 KB (0%)
prosekit/react/inline-popover 30.51 KB (0%)
prosekit/react/popover 14.62 KB (0%)
prosekit/react/resizable 4.64 KB (0%)
prosekit/react/table-handle 35.36 KB (0%)
prosekit/react/tooltip 11.94 KB (0%)
prosekit/solid 39.69 KB (0%)
prosekit/solid/autocomplete 47.3 KB (0%)
prosekit/solid/block-handle 27.09 KB (0%)
prosekit/solid/inline-popover 30.51 KB (0%)
prosekit/solid/popover 14.57 KB (0%)
prosekit/solid/resizable 4.56 KB (0%)
prosekit/solid/table-handle 35.34 KB (0%)
prosekit/solid/tooltip 11.91 KB (0%)
prosekit/vue 36.58 KB (0%)
prosekit/vue/autocomplete 47.26 KB (0%)
prosekit/vue/block-handle 27.05 KB (0%)
prosekit/vue/inline-popover 30.42 KB (0%)
prosekit/vue/popover 14.52 KB (0%)
prosekit/vue/resizable 4.47 KB (0%)
prosekit/vue/table-handle 35.25 KB (0%)
prosekit/vue/tooltip 11.8 KB (0%)
prosekit/web 13 B (0%)
prosekit/web/autocomplete 46.78 KB (0%)
prosekit/web/block-handle 26.54 KB (0%)
prosekit/web/inline-popover 30.02 KB (0%)
prosekit/web/popover 14.02 KB (0%)
prosekit/web/resizable 4.03 KB (0%)
prosekit/web/table-handle 34.79 KB (0%)
prosekit/web/tooltip 11.39 KB (0%)

@ocavue ocavue merged commit 478940c into master Apr 18, 2025
15 checks passed
@ocavue ocavue deleted the ocavue/changeset-config branch April 18, 2025 07:35
This was referenced Apr 18, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ocavue