Skip to content

chore: untrack config-tsup.d.ts#973

Merged
ocavue merged 4 commits intomasterfrom
ocavue/types
Apr 11, 2025
Merged

chore: untrack config-tsup.d.ts#973
ocavue merged 4 commits intomasterfrom
ocavue/types

Conversation

@ocavue
Copy link
Copy Markdown
Collaborator

@ocavue ocavue commented Apr 11, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated internal file tracking settings to ensure only the necessary generated files are maintained by version control.
    • Revised module configuration to correctly reference updated type definition files, aligning with the current source structure.
    • Enhanced clarity in public type declarations by explicitly importing required type information.
    • Removed outdated comments in dependency optimization settings to improve code readability and maintainability.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d3d78c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 11, 2025 •
edited
Loading

Walkthrough

The changes update project configuration and type declarations. The .gitignore file now ignores a previously tracked TypeScript declaration file in the distribution folder. In package.json, the export for config-tsup is modified to point to a type definition in the source folder rather than the distribution folder. Additionally, the type declaration file now explicitly imports the Options type from tsup and declares the signature for the config function. Finally, a commented-out line in the Vitest configuration is removed, with no changes to functionality.

Changes

File(s) Change Summary
packages/dev/.gitignore
packages/dev/package.json		 Removed tracking for dist/config-tsup.d.ts in .gitignore and updated the types export in package.json from "./dist/config-tsup.d.ts" to "./src/config-tsup-types.d.ts".
packages/dev/src/config-tsup-types.d.ts Added an import for the Options type from tsup and declared the signature for the config(options?: Options): () => Promise<Options> function.
packages/dev/src/config-vitest.js Removed a commented-out line in the optimizeDeps section, eliminating excluded packages (prettier and prettier/parser-html).

Poem

In the land of code, I’m a jolly hare,
Hopping through files with updates to spare.
Ignored lines and fresh type hints make me smile,
As configuration changes stretch for a mile.
I celebrate these tweaks with a gentle bound —
A rabbit’s joy in each new code found! 🐇

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3695f06 and d3d78c7.

📒 Files selected for processing (4)
  • packages/dev/.gitignore (0 hunks)
  • packages/dev/package.json (1 hunks)
  • packages/dev/src/config-tsup-types.d.ts (1 hunks)
  • packages/dev/src/config-vitest.js (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/dev/src/config-vitest.js
  • packages/dev/.gitignore
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: test-e2e (1)
🔇 Additional comments (2)
packages/dev/src/config-tsup-types.d.ts (1)

1-3: Solid Type Definition Addition!

The explicit import of the Options type from the tsup package enhances clarity and type safety for the configuration function. The declaration
export declare function config(options?: Options): () => Promise<Options>
accurately represents the intended contract.

packages/dev/package.json (1)

8-12: Accurate Update of Type Definitions Path.

Updating the "types" property for the ./config-tsup export from the dist directory to point to "./src/config-tsup-types.d.ts" correctly reflects the new location of type declarations. This change ensures that consumers reference the proper type definitions and aligns with the project's updated configuration strategy.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 11, 2025 •
edited
Loading

Open in StackBlitz

@prosekit/basic

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/basic@973

@prosekit/core

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/core@973

@prosekit/lit

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/lit@973

@prosekit/extensions

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/extensions@973

@prosekit/pm

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/pm@973

@prosekit/preact

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/preact@973

prosekit

npm i https://pkg.pr.new/prosekit/prosekit@973

@prosekit/react

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/react@973

@prosekit/solid

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/solid@973

@prosekit/svelte

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/svelte@973

@prosekit/vue

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/vue@973

@prosekit/web

npm i https://pkg.pr.new/prosekit/prosekit/@prosekit/web@973

commit: d3d78c7

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

size-limit report 📦

Path Size
prosekit/basic 65.79 KB (0%)
prosekit/basic/style.css 1018 B (0%)
prosekit/basic/typography.css 666 B (0%)
prosekit/core 62.16 KB (0%)
prosekit/core/test 51.06 KB (0%)
prosekit/extensions 13 B (0%)
prosekit/extensions/autocomplete 28.96 KB (0%)
prosekit/extensions/blockquote 21.37 KB (0%)
prosekit/extensions/bold 21.65 KB (0%)
prosekit/extensions/code 21.51 KB (0%)
prosekit/extensions/code-block 1.05 MB (0%)
prosekit/extensions/commit 31.56 KB (0%)
prosekit/extensions/commit/style.css 60 B (0%)
prosekit/extensions/doc 10.5 KB (0%)
prosekit/extensions/drop-cursor 14.73 KB (0%)
prosekit/extensions/enter-rule 15.14 KB (0%)
prosekit/extensions/file 14.42 KB (0%)
prosekit/extensions/gap-cursor 30.1 KB (0%)
prosekit/extensions/gap-cursor/style.css 149 B (0%)
prosekit/extensions/heading 21.64 KB (0%)
prosekit/extensions/horizontal-rule 15.71 KB (0%)
prosekit/extensions/image 14.96 KB (0%)
prosekit/extensions/input-rule 15.08 KB (0%)
prosekit/extensions/italic 21.55 KB (0%)
prosekit/extensions/link 25.63 KB (0%)
prosekit/extensions/list 40.9 KB (0%)
prosekit/extensions/list/style.css 450 B (0%)
prosekit/extensions/loro 19.28 KB (0%)
prosekit/extensions/loro/style.css 181 B (0%)
prosekit/extensions/mark-rule 14.43 KB (0%)
prosekit/extensions/mention 14.92 KB (0%)
prosekit/extensions/mod-click-prevention 13.84 KB (0%)
prosekit/extensions/paragraph 20.24 KB (0%)
prosekit/extensions/placeholder 33.01 KB (0%)
prosekit/extensions/placeholder/style.css 61 B (0%)
prosekit/extensions/readonly 13.76 KB (0%)
prosekit/extensions/search 30.45 KB (0%)
prosekit/extensions/search/style.css 117 B (0%)
prosekit/extensions/strike 21.56 KB (0%)
prosekit/extensions/table 44.82 KB (0%)
prosekit/extensions/table/style.css 241 B (0%)
prosekit/extensions/text 10.5 KB (0%)
prosekit/extensions/text-align 20.3 KB (0%)
prosekit/extensions/underline 20.58 KB (0%)
prosekit/extensions/virtual-selection 28.52 KB (0%)
prosekit/extensions/virtual-selection/style.css 64 B (0%)
prosekit/extensions/yjs 19.49 KB (0%)
prosekit/extensions/yjs/style.css 192 B (0%)
prosekit/lit 13 B (0%)
prosekit/lit/autocomplete 46.76 KB (0%)
prosekit/lit/block-handle 26.57 KB (0%)
prosekit/lit/inline-popover 30.01 KB (0%)
prosekit/lit/popover 14.07 KB (0%)
prosekit/lit/resizable 4.03 KB (0%)
prosekit/lit/table-handle 34.77 KB (0%)
prosekit/lit/tooltip 11.41 KB (0%)
prosekit/pm 13 B (0%)
prosekit/pm/commands 15.86 KB (0%)
prosekit/pm/history 13.55 KB (0%)
prosekit/pm/inputrules 11.8 KB (0%)
prosekit/pm/keymap 11.72 KB (0%)
prosekit/pm/model 12.71 KB (0%)
prosekit/pm/state 16.8 KB (0%)
prosekit/pm/transform 14.62 KB (0%)
prosekit/pm/view 39.91 KB (0%)
prosekit/pm/view/style/prosemirror.css 259 B (0%)
prosekit/preact 19.55 KB (0%)
prosekit/preact/autocomplete 47.32 KB (0%)
prosekit/preact/block-handle 27.22 KB (0%)
prosekit/preact/inline-popover 30.52 KB (0%)
prosekit/preact/popover 14.62 KB (0%)
prosekit/preact/resizable 4.63 KB (0%)
prosekit/preact/table-handle 35.41 KB (0%)
prosekit/preact/tooltip 11.97 KB (0%)
prosekit/react 36.49 KB (0%)
prosekit/react/autocomplete 47.31 KB (0%)
prosekit/react/block-handle 27.11 KB (0%)
prosekit/react/inline-popover 30.59 KB (0%)
prosekit/react/popover 14.62 KB (0%)
prosekit/react/resizable 4.64 KB (0%)
prosekit/react/table-handle 35.36 KB (0%)
prosekit/react/tooltip 11.94 KB (0%)
prosekit/solid 39.68 KB (0%)
prosekit/solid/autocomplete 47.24 KB (0%)
prosekit/solid/block-handle 27.07 KB (0%)
prosekit/solid/inline-popover 30.47 KB (0%)
prosekit/solid/popover 14.58 KB (0%)
prosekit/solid/resizable 4.55 KB (0%)
prosekit/solid/table-handle 35.26 KB (0%)
prosekit/solid/tooltip 11.92 KB (0%)
prosekit/vue 36.57 KB (0%)
prosekit/vue/autocomplete 47.19 KB (0%)
prosekit/vue/block-handle 27.05 KB (0%)
prosekit/vue/inline-popover 30.36 KB (0%)
prosekit/vue/popover 14.52 KB (0%)
prosekit/vue/resizable 4.47 KB (0%)
prosekit/vue/table-handle 35.25 KB (0%)
prosekit/vue/tooltip 11.8 KB (0%)
prosekit/web 13 B (0%)
prosekit/web/autocomplete 46.78 KB (0%)
prosekit/web/block-handle 26.54 KB (0%)
prosekit/web/inline-popover 29.96 KB (0%)
prosekit/web/popover 14.02 KB (0%)
prosekit/web/resizable 4.03 KB (0%)
prosekit/web/table-handle 34.79 KB (0%)
prosekit/web/tooltip 11.39 KB (0%)

@ocavue ocavue marked this pull request as ready for review April 11, 2025 09:38
@ocavue ocavue changed the title chore: untrack config-tsup.d.ts chore: untrack config-tsup.d.ts Apr 11, 2025
@ocavue ocavue merged commit 2670c6a into master Apr 11, 2025
16 checks passed
@ocavue ocavue deleted the ocavue/types branch April 11, 2025 09:46
This was referenced Apr 18, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ocavue