Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres): integer cannot fit github job ids #414

Merged
merged 1 commit into from
Oct 27, 2024
Merged

fix(postgres): integer cannot fit github job ids #414

merged 1 commit into from
Oct 27, 2024

Conversation

marcusramberg
Copy link
Contributor

Tried migrating our sqlite backend to postgres and noticed there's a problem in
the pg schema:

"error":"failed to find record: pq: value \"32108935124\" is out of range for type integer"}

@marcusramberg
Copy link
Contributor Author

Tested locally to confirm the migration works.

@tboerger
Copy link
Member

Interesting, maybe it's better to have one query per migration?

@marcusramberg
Copy link
Contributor Author

Interesting, maybe it's better to have one query per migration?

Ok, yeah I see that's the official recommendation in Darwin. I've updated it to be like that now.

@tboerger tboerger enabled auto-merge October 27, 2024 15:14
@tboerger tboerger merged commit a09b96b into promhippie:master Oct 27, 2024
16 checks passed
@tboerger tboerger added this to the v4.0.1 milestone Oct 27, 2024
@tboerger tboerger added the bug Something isn't working label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusramberg @tboerger