Fix for PR #298 to drop out of order webhook events #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raz-amir
changed the title
|
@tboerger, this fixes the issue. Sorry about that. I wasn't sure if you would want a separate changelog, so I added one just in case. Added some debug information to the logs, that I think is useful, but feel free to drop it. |
|
The new release haven't been tagged, please drop the extra changelog and just add the pull request url to the existing one. |
|
I have applied some minor changes and will merge it when it's green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PR #298 that fixed #296
The code didn't query the db for the
updated_atfield, so the comparison was always to0timestamp. Also added some info to the debug prints