api: add listType markers to AlertmanagerConfig v1alpha1 #8207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varundeepsaini
force-pushed
the
ssatags-v1alpha1-alertmanagerconfig
branch
from
4f39d3f to
ef01795
Compare
Contributor
Author
|
@simonpasquier Could you review these, please |
Contributor
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
Good job! For listType=set, I'd reserve it for lists which Alertmanager rejects if they are not sets.
Contributor
Author
|
@simonpasquier have pushed the changes, please review again |
| // Labels must not be repeated (unique list). | ||
| // Special label "..." (aggregate by all possible labels), if provided, must be the only element in the list. | ||
| // +listType=set | ||
| // +listType=atomic |
Contributor
There was a problem hiding this comment.
sorry for being unclear but a set here is ok (because Alertmanager would fail if duplicated groupby values are provided)
|
|
||
| // muteTimeIntervals is a list of MuteTimeInterval names that will mute this route when matched, | ||
| // +listType=set | ||
| // +listType=atomic |
| MuteTimeIntervals []string `json:"muteTimeIntervals,omitempty"` | ||
| // activeTimeIntervals is a list of MuteTimeInterval names when this route should be active. | ||
| // +listType=set | ||
| // +listType=atomic |
Contributor
Author
|
@simonpasquier my bad, reverted those specific changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SSA (Server-Side Apply) listType markers to all slice fields in
v1alpha1/alertmanager_config_types.goto satisfy the KAL ssatags linter.listType=atomicfor complex object lists (configs, matchers, etc.)listType=setfor unique string lists (GroupBy, MuteTimeIntervals, ActiveTimeIntervals, MrkdwnIn, Equal)Related to: #8131
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Ran the linter locally, no violations left in this file
Changelog entry