Feat: Add Config Generator for Alertmanager's Mattermost Receiver #8188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Contributor
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
The WebhookURL value needs to be checked?
Contributor
Author
|
@simonpasquier I didn't see any other sanitize methods check it. I plan to implement it with CR when converting it. wdyt? |
Contributor
Right, we don't do it for the other receivers so let's not do it there though I would love if the controller could prevent a bad config secret to be deployed. |
Contributor
Author
|
@simonpasquier Let me create an issue on this so we won't miss it. |
This was referenced Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alertmanager 0.30.0 supports Mattermost receiver. This PR adds the config generator for Alertmanager to support the Mattermost integration.
Close: #8164
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Unit Testing
Changelog entry