feat: add scrape_native_histograms
#8102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
Shouldn't we also add the same field to the Prometheus/PrometheusAgent top-level spec (CommonPrometheusFields struct)?
heliapb
force-pushed
the
feat/add_scrape_native_histograms
branch
from
a5f3c99 to
b2e3fdc
Compare
Member
Author
yes, forgot to add, fixed now, thanks |
heliapb
force-pushed
the
feat/add_scrape_native_histograms
branch
from
331d9ef to
12bc23f
Compare
heliapb
force-pushed
the
feat/add_scrape_native_histograms
branch
from
12bc23f to
ad63051
Compare
heliapb
force-pushed
the
feat/add_scrape_native_histograms
branch
from
ad63051 to
2be6fb2
Compare
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
heliapb
force-pushed
the
feat/add_scrape_native_histograms
branch
from
2be6fb2 to
0c016a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From prometheus 3.8.0 add scrape_native_histograms
https://github.com/prometheus/prometheus/pull/17315/files
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.