feat: add azure auth workload_identity #7998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hmm the new options are for remote write configurations not scrape configurations? |
heliapb
force-pushed
the
feat/azure_workloadidentity
branch
from
95eb44b to
1b66005
Compare
Contributor
|
#7815 (comment) also applies here. |
heliapb
force-pushed
the
feat/azure_workloadidentity
branch
2 times, most recently
from
c3e6bce to
54ebcc7
Compare
heliapb
force-pushed
the
feat/azure_workloadidentity
branch
from
54ebcc7 to
ce50e53
Compare
heliapb
force-pushed
the
feat/azure_workloadidentity
branch
2 times, most recently
from
3d634c1 to
9f26e0e
Compare
5 tasks
heliapb
force-pushed
the
feat/azure_workloadidentity
branch
2 times, most recently
from
03cf7c6 to
0c8dc81
Compare
Contributor
|
We also need to implement the feature in the ThanosRuler controller. |
heliapb
force-pushed
the
feat/azure_workloadidentity
branch
from
9f9b712 to
202f4b9
Compare
| if spec.AzureAD.ManagedIdentity == nil && spec.AzureAD.OAuth == nil && spec.AzureAD.SDK == nil { | ||
| return fmt.Errorf("must provide Azure Managed Identity or Azure OAuth or Azure SDK in the Azure AD config") | ||
| if spec.AzureAD.ManagedIdentity == nil && spec.AzureAD.OAuth == nil && spec.AzureAD.SDK == nil && spec.AzureAD.WorkloadIdentity == nil { | ||
| return fmt.Errorf("must provide Azure Managed Identity, Azure OAuth, Azure SDK, or Azure Workload Identity in the Azure AD config") |
Contributor
There was a problem hiding this comment.
this could become a CEL expression (as a follow-up).
Member
Author
There was a problem hiding this comment.
ok then, just to clarify, to open a follow up pr with the cel validations then?
Member
Author
There was a problem hiding this comment.
got it, will work on this as follow up
heliapb
force-pushed
the
feat/azure_workloadidentity
branch
from
d678b82 to
79907f3
Compare
pkg/prometheus/testdata/RemoteWriteConfigAzureADWorkloadIdentity_v3.7.0.golden
Show resolved
Hide resolved
Contributor
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
LGTM but the tests need to be fixed.
Signed-off-by: Hélia Barroso <[email protected]>
Co-authored-by: Simon Pasquier <[email protected]>
Co-authored-by: Simon Pasquier <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
Signed-off-by: Hélia Barroso <[email protected]>
heliapb
force-pushed
the
feat/azure_workloadidentity
branch
from
1ed4736 to
e9c0e32
Compare
simonpasquier
approved these changes
Jan 7, 2026
This was referenced Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for workload_identity in azure auth, as part of the new prometheus version 3.7
prometheus/prometheus#16788
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.