feat: add support for configuring use_fips_sts_endpoint in sigv4 config
#7987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig Using `AWS_USE_FIPS_ENDPOINT` to configure FIPS endpoint usage no longer works (see prometheus/prometheus#16752). This must be done using the `use_fips_sts_endpoint` config option added in prometheus/common#649. It is also available in the new sigv4 package: https://github.com/prometheus/sigv4. Fixes prometheus-operator#7986 Signed-off-by: Sam McBroom <[email protected]>
Contributor
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
Thanks! One small nit otherwise as I mentioned in the previous PR, the Prometheus docs would also deserve an update I believe:
Unrelated but it seems that the option isn't documented: https://prometheus.io/docs/prometheus/latest/configuration/configuration/
| // roleArn defines the named AWS profile used to authenticate. | ||
| // +optional | ||
| RoleArn string `json:"roleArn,omitempty"` | ||
| // useFIPSSTSEndpoint defines FIPS mode for AWS STS endpoint. |
Contributor
There was a problem hiding this comment.
(nit)
Suggested change
| // useFIPSSTSEndpoint defines FIPS mode for AWS STS endpoint. | |
| // useFIPSSTSEndpoint defines the FIPS mode for the AWS STS endpoint. |
Contributor
Author
|
Will do! Thanks so much! |
This was referenced Oct 7, 2025
4 tasks
This was referenced Nov 16, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
AWS_USE_FIPS_ENDPOINTto configure FIPS endpoint usage no longer works (see prometheus/prometheus#16752). This must be done using theuse_fips_sts_endpointconfig option added in prometheus/common#649. It is also available in the new sigv4 package: https://github.com/prometheus/sigv4.Fixes #7986
Description
Allows configuring the
use_fips_sts_endpointoption in the sigv4 config block. We did have a draft PR for this that can be closed: #7986.Closes: #7986
The minimum Prometheus version was determined by:
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Added a new unit test entry.
Changelog entry