Skip to content

Conversation

@nutmos
Copy link
Contributor

@nutmos nutmos commented Oct 1, 2025

Description

Improve CRD validations and test cases for Kuma SD. This PR picks up after #7379 and #7697
Co-Author: @Dharma-09, @mviswanathsai

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

E2E test cases

Changelog entry

- Add CRD validation for Kuma SD and test cases

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nutmos nutmos marked this pull request as ready for review October 2, 2025 01:42
@nutmos nutmos requested a review from a team as a code owner October 2, 2025 01:42
@nutmos nutmos requested a review from simonpasquier October 2, 2025 01:42
@nutmos
Copy link
Contributor Author

nutmos commented Oct 2, 2025

@simonpasquier Updated the status from draft to open. Please merge PR. Thanks!

@simonpasquier simonpasquier merged commit 15a6fc9 into prometheus-operator:main Oct 2, 2025
22 checks passed
@simonpasquier
Copy link
Contributor

Thanks! I wasn't sure about the draft status indeed :)

@nutmos nutmos mentioned this pull request Oct 3, 2025
This was referenced Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants