Feat: Add Webex in Global Config #7632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliapb
reviewed
Jun 25, 2025
| // It requires Alertmanager >= v0.25.0. | ||
| // +kubebuilder:validation:Pattern:="^(http|https)://.+$" | ||
| // +optional | ||
| APIURL *string `json:"apiURL,omitempty"` |
Member
There was a problem hiding this comment.
Hi @nutmos I guess this needs to be changed to *URL as in https://github.com/prometheus-operator/prometheus-operator/blob/main/pkg/apis/monitoring/v1beta1/alertmanager_config_types.go#L657
nutmos
force-pushed
the
feat/add-webex-global-config
branch
from
9b5ffb6 to
dedc355
Compare
Contributor
Author
|
@simonpasquier @heliapb Please review this PR for the next one. |
heliapb
approved these changes
Jul 1, 2025
Co-authored-by: Simon Pasquier <[email protected]>
Contributor
Author
|
@simonpasquier @heliapb Could you pleaes review it again? |
Contributor
Author
|
@simonpasquier @slashpai Anyone available for review please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add global config support in the alert manager for Webex.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Using unit tests for validation
Changelog entry