feat: add startupProbe to config-reloader #7575
Merged
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliapb
approved these changes
Jun 2, 2025
Contributor
|
Thanks for the submission! Can you also add prometheus-operator/cmd/operator/main.go Line 158 in 71db25c |
thaniri
force-pushed
the
issue-7494-add-startup-probe-config-reloader
branch
from
2620601 to
f70c5dc
Compare
Contributor
Author
Yes @simonpasquier, great catch to make sure that the config flag is documented properly. Apologies for missing that. |
Contributor
|
ah you'll need to regenerate the documentation running |
This is for GitHub issue prometheus-operator#7494. Adds startup probe to the config-reloader sidecar for Prometheus containers. Only takes affect if the --enable-config-reloader-probes flag is set on the prometheus-operator pod for the config-reloader container.
thaniri
force-pushed
the
issue-7494-add-startup-probe-config-reloader
branch
from
f70c5dc to
adf64aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is for GitHub issue #7494.
Adds startup probe to the config-reloader sidecar for Prometheus pods. Only takes affect if the --enable-config-reloader-probes flag is set on the prometheus-operator pod.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Unit tests pass. Local build of prometheus-operator in a local kind cluster passes.
Changelog entry
Startup probe added to config-reloader sidecar if --enable-config-reloader-probes set.